Android Oreo Issues Has Been Resolved.

[zeeshanrasool91]

Process Phoenix Has Been Added for restarting Application work better then refresh method....

[iamjazzar]

Hello @zeeshanrasool91, and thanks for the contribution. Is this ready for review now?

[zeeshanrasool91]

yes it is ready for review

[zeeshanrasool91]

Process Pheonix was Creating Issue when we included just because of Some intent filters

On Fri, Jun 29, 2018 at 5:14 PM Ahmed Jazzar [email protected] wrote:

@ahmedaljazzar requested changes on this pull request.

In app/src/main/java/com/ahmedjazzar/rosetta/app/MainApplication.java https://github.com/ahmedaljazzar/rosetta/pull/30#discussion_r199139270:

@@ -1,7 +1,11 @@ package com.ahmedjazzar.rosetta.app;

import android.app.Application; +import android.content.Context;

Why all these unused imports?

In app/src/main/res/values-v21/styles.xml https://github.com/ahmedaljazzar/rosetta/pull/30#discussion_r199139354:

@@ -4,6 +4,6 @@ false true true

•    <item name="android:statusBarColor">@android:color/transparent</item>
  

•    <item name="android:statusBarColor">@color/colorPrimaryDark</item>
  

Is this change necessary?

In build.gradle https://github.com/ahmedaljazzar/rosetta/pull/30#discussion_r199139469:

@@ -15,6 +16,7 @@ buildscript { allprojects { repositories { jcenter()

•    google()
  

Are we using this repository?

In rosetta/src/main/java/com/ahmedjazzar/rosetta/LanguagesListDialogFragment.java https://github.com/ahmedaljazzar/rosetta/pull/30#discussion_r199139635:

@@ -153,7 +153,8 @@ protected void onPositiveClick() { getActivity(), mSelectedLanguage)) {

             mLogger.info("App locale changed successfully.");

•            LocalesUtils.refreshApplication(getActivity());
  

•            //LocalesUtils.refreshApplication(getActivity());
  

Just remove it

In rosetta/src/main/java/com/ahmedjazzar/rosetta/LocalesUtils.java https://github.com/ahmedaljazzar/rosetta/pull/30#discussion_r199139665:

@@ -265,7 +265,8 @@ static boolean setLocale(Locale newLocale, Activity activity) { }

     if (LocalesUtils.setAppLocale(activity.getApplicationContext(), newLocale))   {

•        LocalesUtils.refreshApplication(activity);
  

•        //LocalesUtils.refreshApplication(activity);
  

Just remove it.

In rosetta/src/main/java/com/ahmedjazzar/rosetta/ProcessPhoenix.java https://github.com/ahmedaljazzar/rosetta/pull/30#discussion_r199139854:

@@ -0,0 +1,131 @@ +/*

Can't we just include it instead of copying and pasting it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ahmedaljazzar/rosetta/pull/30#pullrequestreview-133201015, or mute the thread https://github.com/notifications/unsubscribe-auth/AHFTed1n9CtmLgq7GP1mxwYfXVSSbVY9ks5uBhpDgaJpZM4UyAYl .

-- Regards: Zeeshan Rasool

[zeeshanrasool91]

@ahmedaljazzar now you can Check and tell me