iceball icon indicating copy to clipboard operation
iceball copied to clipboard

Safer engine functions

Open BR- opened this issue 10 years ago • 3 comments

common.map_set will crash if called on an improper map. It should instead throw a Lua error. I suspect there are many other functions like this.

BR- avatar Feb 07 '15 08:02 BR-

Something in the networking will crash too. I think net_unpack may crash if the buffer isn't long enough. net_pack should probably be checked too (then again, most of them should probably at least get a look at them).

rakiru avatar Feb 07 '15 17:02 rakiru

Especially the map functions are REALLY crashy, partly because of all the "dirty" pillar/column stuff. I wonder why iceball uses the vxl format instead of something like in PySnip.

LeComm avatar Feb 08 '15 14:02 LeComm

Because it's faster to look geometry up with and it uses less memory.

iamgreaser avatar Feb 08 '15 20:02 iamgreaser