Gabriel Maldonado

[Woo POS] Improvement: Extract `updateSharedConfiguration` to separate methods

1

Follow-up from https://github.com/woocommerce/woocommerce-ios/pull/13670#discussion_r1724646148 > I think we'd have problems if there was no tabBarController, but strictly there's no reason that this should prevent us from disabling the in app notifications...

[Woo POS] M2 Analytics: Payment events

1

Part of https://github.com/woocommerce/woocommerce-ios/issues/13277 ``` Payment Success card_present_collect_payment_success Payment Flow Error: card_present_collect_payment_failed (error_type: string) ```

[Woo POS] M2 Analytics: Order events

1

Part of https://github.com/woocommerce/woocommerce-ios/issues/13277 ``` Order Creation Error: order_creation_failed (error_type: string) ```

[Woo POS] M2: Analytics

2

Since we've abstracted Analytics to a protocol in preparation for M1, we can inject the abstraction through the entry point and then specialize it as needed for our case: ```diff...

[Woo POS] Unit tests for `TotalsViewModel`

1

From the refactor on https://github.com/woocommerce/woocommerce-ios/pull/13211#discussion_r1661382406 we can now test the expected functionality of this bit. A starter list can be found in `TotalsViewModelTests`: ``` func test_isSyncingOrder() {} func test_startSyncOrder() {}...

[Woo POS] Explore moving state from `ItemListState` to dashboard

1

As follow-up from https://github.com/woocommerce/woocommerce-ios/pull/13532/files#r1710626891 now that the `ItemListState` cases for `.empty` and `.error` are rendered in the dashboard, and not within the Item List view component, we could move these...

[Woo POS] Technical: Improvements on `PointOfSaleDashboardViewModel` state handling

1

This is a follow-up from https://github.com/woocommerce/woocommerce-ios/pull/13361 Ref: https://github.com/woocommerce/woocommerce-ios/pull/13361#discussion_r1682265685 > My suggestion was to move such checks to VM ( PointOfSaleDashboardViewModel), so it would be viewModel.isCartShown Ref: https://github.com/woocommerce/woocommerce-ios/pull/13361#discussion_r1682272374 > isEmptyOrError likely...

[Order creation] Update coupons display order details

3

Closes: #14097 Ref: pe5pgL-5G4-p2#comment-4599 This PR updates the how coupons are displayed during Order creation. Since we do not have a design proposal here, we just went along copying and...

Order details: Update how applied coupons are displayed

1

Ref: pe5pgL-5G4-p2#comment-4599 Related: https://github.com/woocommerce/woocommerce-ios/issues/13861 Android: https://github.com/woocommerce/woocommerce-android/pull/12737 Now: Intended:

Custom Amounts UI placeholder shows additional spaces if these were added to store settings

1

If we add spaces to the currency separators under WooCommerce > Settings > General, these additional spaces can be seen in the placeholder amount when creating a custom amount to...