godot-git-control icon indicating copy to clipboard operation
godot-git-control copied to clipboard

Godot 3

Open testman42 opened this issue 7 years ago • 12 comments

Will this work in Godot 3 in it's current state?

If no, will you make it compatible?

testman42 avatar Dec 22 '17 09:12 testman42

Godot 3 stable is out now.

testman42 avatar Jan 30 '18 21:01 testman42

@testman42 I ported it to Godot 3.0-stable at https://github.com/deep-gaurav/godot-git-control

I would make a PR but I think @funabab isnot active, so instead I'll get it to asset library

deep-gaurav avatar Mar 05 '18 12:03 deep-gaurav

Nice, awesome work. 👍

Also, I admire you for creating whole new protocol that will in time succeed the https:// protocol 😄

Could you do two things:

  1. Enable making issues in your forked repo?
  2. Check if it works with Godot 3.0.2 (latest maintenance release as of now)

testman42 avatar Mar 05 '18 14:03 testman42

@testman42, lol, thanks corrected typo, and to answer your questions,

  1. Sure I'll, give me a moment,
  2. Nope, it works only with Godot 3.0-stable, It hangs in 3.0.1 and 3.0.2, I don't know why,

deep-gaurav avatar Mar 05 '18 14:03 deep-gaurav

@testman42 OK you can now create issues in the fork

deep-gaurav avatar Mar 05 '18 14:03 deep-gaurav

nice to discover interest in this plugin :), haven't been able to update it for over a year now cause i was busy with other commitments.. Mere glimpse at the made me realize that there is need for some changes so am planning on creating a new branch for new version which i will start working on hopefully this weekend

iamfunsho avatar Mar 06 '18 11:03 iamfunsho

I will be working with a custom build of godot, so hopefully if all things go well it should work with any 3.x version

iamfunsho avatar Mar 06 '18 11:03 iamfunsho

Actually I figured out the problem, it was something with DynamicFont, I fixed it, though :D

deep-gaurav avatar Mar 06 '18 15:03 deep-gaurav

I'll make a PR if you would like, tomorrow maybe..

deep-gaurav avatar Mar 06 '18 15:03 deep-gaurav

Do it. 👍 Don't let there be two separate repos trying to achieve the same goal.

testman42 avatar Mar 06 '18 15:03 testman42

It's here.... any testing before closing

iamfunsho avatar Apr 03 '18 01:04 iamfunsho

Awesome. I will give it a try later today once I get home.

testman42 avatar Apr 03 '18 06:04 testman42