diagnostic-languageserver icon indicating copy to clipboard operation
diagnostic-languageserver copied to clipboard

Published 20 hours ago • verified publisher icon iamcco

illogical sourceName

Open helmecke opened this issue 4 years ago • 3 comments

Describe the bug sourceName shows partial filepath.

It is caused by the workaround in: https://github.com/iamcco/diagnostic-languageserver/pull/30 https://github.com/iamcco/coc-diagnostic/pull/49

Expected behavior sourceName should contain the name of the linter not the filename.

Screenshots image

Desktop (please complete the following information):

  • OS: Arch Linux (Linux 5.8.10-arch1-1)

helmecke avatar Sep 23 '20 10:09 helmecke

It's relative to:

  • https://github.com/iamcco/diagnostic-languageserver/issues/24
  • https://github.com/iamcco/diagnostic-languageserver/pull/26

cc @fsouza since https://github.com/iamcco/diagnostic-languageserver/pull/30, it can filter diagnostics for the current file by sourceNameFilter option. Is it still worth to show the file path?

iamcco avatar Sep 23 '20 11:09 iamcco

Ohhh shoot, that was my bad. Yeah let's revert that change, I'll send another PR that sets the filename in the correct field.

fsouza avatar Sep 23 '20 12:09 fsouza

We don't need to revert the change, sourceName is now used by the sourceNameFilter options by pr #30 , we only need to do some change.

iamcco avatar Sep 24 '20 02:09 iamcco