SQLParser icon indicating copy to clipboard operation
SQLParser copied to clipboard

Deprecated: Creation of dynamic property iamcal\SQLParser::$sql is deprecated

Open stAn47 opened this issue 1 year ago • 1 comments

Hello, please add

private $sql = '';

to SQLParser.php file for php8.3+ compatibility.

or extend from stdClass if dynamic properties are needed.

best regards, stan

stAn47 avatar Mar 20 '24 11:03 stAn47

Can you describe the problem? $sql is already declared as a public var and the tests are passing fine under PHP 8.3

iamcal avatar Mar 22 '24 22:03 iamcal

Hey @stAn47 @iamcal, I think the issue here is that the commit that added the $sql property (https://github.com/iamcal/SQLParser/commit/1fe57fa39d6de91fc7a2988a7d0c205becbcf341) hasn't been included in a release on Packagist yet.

Tagging a new release should solve it. 😊

zepfietje avatar May 24 '24 07:05 zepfietje

Ahh, that makes sense. v0.5 is now on Packagist: https://packagist.org/packages/iamcal/sql-parser

iamcal avatar May 29 '24 17:05 iamcal

Thanks, Cal!

zepfietje avatar May 30 '24 10:05 zepfietje