ColorHelper icon indicating copy to clipboard operation
ColorHelper copied to clipboard

Colour Structs

Open martindevans opened this issue 9 months ago • 0 comments

This PR proposes a breaking change.

Currently, this library causes lots of unavoidable allocations. That makes it unusable when developing games, where performance is critical and allocations should be avoided as much as possible.

To fix this, I've converted all of the colour structs from class to readonly record struct.

An added benefit of this change is removing all of the handwritten equality implementations (we get it for free from record), which were broken! For example this would previously crash instead of return false:

var rgb = new RGB(1, 2, 3);
var hsl = new HSL(1, 2, 3);
Assert.IsFalse(rgb.Equals(hsl));

martindevans avatar Mar 24 '25 01:03 martindevans