iamanigeeit

Results 20 comments of iamanigeeit

@sw005320 @Fhrozen For `test python`, I can modify the files to fit the 80 char limit per line. I was using 120 chars as the limit because it looks like...

> > For `check_kaldi_symlinks`, does it mean that `copy_data_dir.sh` must be identical between `egs2/TEMPLATE/asr1/utils` and `tools/kaldi/egs/wsj/s5` ? Should I send a PR for kaldi to make them match? > >...

It looks like the entire directory `egs2/TEMPLATE/asr1/utils` must be identical to `tools/kaldi/egs/wsj/s5`. In that case, i don't know where to add `copy_tts_data_dir.sh`. Can i just make the PR for Kaldi?...

@Fhrozen I have added `test_cleaners.py`. However, i don't know enough Japanese, Korean or Vietnamese to write tests for those. Is there a way to pause or stop the CI checks...

@Fhrozen I added [skip ci] at https://github.com/espnet/espnet/pull/5680 but it's still running the checks, is there anything else i have to do?

> Hi @iamanigeeit, I do not follow all conversations with @Fhrozen, but we have a CI issue in https://github.com/espnet/espnet/actions/runs/8048817075/job/21980956442?pr=5670#step:8:37 > > Can you fix it? Hi @sw005320 -- The CI...

> I think whisper is installed in our basic CI https://github.com/espnet/espnet/blob/master/ci/install.sh#L24, but probably it is too old? I see the problem now. ``` tools/venv/lib/python3.7/site-packages/setuptools/_distutils/msvccompiler.py:70 ... tools/chainer/chainer/_environment_check.py:7 ... ``` The test...

Conda installation problems were caused by installing `ffmpeg` from conda-forge (see `installers/install_ffmpeg_conda.sh` for details). I have updated the Makefile and ffmpeg installation to solve it. The root cause is https://github.com/conda-forge/ocl-icd-feedstock/issues/29...

Hi @sw005320 @Fhrozen -- would it be ok to merge now? The only CI checks that fail are `test_utils/test_compute-cmvn-stats_py.bats` `test_utils/test_copy-feats_py.bats` Both are not related to this PR.

@HarryHe11 Not sure if it's related but my problem went away when installed scikit-learn and scipy.