go-win64api icon indicating copy to clipboard operation
go-win64api copied to clipboard

Allow custom an Action when create new rule

Open mrpk1906 opened this issue 3 years ago • 1 comments

Hello @iamacarpet

I created a new branch to allow custom an Action in firewall module Please close this pull request: https://github.com/iamacarpet/go-win64api/pull/31

Thank you!

mrpk1906 avatar Mar 16 '21 14:03 mrpk1906

Hi! First, thank you for PR!

I should appear here earlier, so sorry for big delay.

I am not sure if this is very useful when following function exists : FirewallRuleAddAdvanced(rule FWRule)

rule.Action allows you to set custom action.

IMHO most of admins/users works with firewall with whitelisting logic, so custom action is not commonly used and for special cases mentioned function should be good to use.

Have a great day and again - thanks for contribution!

ernierasta avatar Oct 13 '21 08:10 ernierasta