Results 14 comments of Joe Taylor

I appreciate you trying to fix this, as I have the same issue. This however doesn't autofix anything on my codebase now.

I found the problem. Older versions of eslint don't handle the mergeFixes. That is when you return an array of fixes. https://github.com/eslint/eslint/blob/6ab04b553ec3ecb65ed3473b3f873b5a72af3675/lib/report-translator.js#L173 So if you stub out that mergeFixes, I...

If you want to make a branch on your repo I can PR to it. On Wed, Jan 24, 2018 at 2:50 PM Iacami Gevaerd wrote: > @iamJoeTaylor could you...

Sorry I replied from my phone and thought you were someone else. 😝 I'll work on explaining more clearly.

@enapupe So I can actually code this up so maybe it can get merged in at some point. But I used the code in this PR but I added https://github.com/eslint/eslint/blob/4f898c74b4bdfea52c7cd9b8d2bf12c3c349eb88/lib/report-translator.js#L136-L170...

@enapupe https://github.com/valentin-nemcev/eslint-plugin-import-order-autofix/pull/1 cc @valentin-nemcev

Just saw this PR too: https://github.com/jrlucier/eero_tracker/pull/29 Curious why it was closed, and if there is something that should be updated.

Good point, I think there has been others confused with this as well. I'll come up with another number formatter demo. Thanks

@gqqnbig thanks for reporting I've been on vacation. I'll check this out and get a fix out for you.

@gqqnbig I'll investigate. Could you give me another repro sequence so I can make a failing test case again. I wasn't aware there was more than one failing case.