Iain Beeston

Results 190 comments of Iain Beeston

You know, activesupport's as_json method is basically a superior version of this. It's defined on a number of base classes (Array, Hash, Symbol etc) and it recursively converts all symbols...

I only realised today! (I've even written code before that's includes symbols in the result of as_json! Whoops!) I like the other changes in this PR though. I wonder if...

Yes I agree, that makes sense On Sun, 15 Mar 2015 at 4:51 pm, Jonas Peschla [email protected] wrote: > Should we drop the :parse_data option as well then? I think...

I think add something into the readme now. It doesn't have to be perfect (we can revise the whole readme later), but at least we can't forget if we add...

Yeah, this is a good point. I suggest we start this from version 3.0

#206 will fix this issue

For my own purposes: 1. Yes. The way I have it set up, other resources have an “entries” association. The entry resource only really has an association and index view...

I'd try something like this instead, which avoids duplicating the code in the passwordless controllers ``` class Users::MagicLinksController < Devise::MagicLinksController def show super do |resource| resource.confirm unless resource.confirmed? end end...

This issue bothers me too. I don't have a solution for it, unfortunately. I think my preferred solution would be that if the user clicks the link anywhere, it signs...

I've added an example gem that has this issue too (although simply running gem install as above might be simpler) https://github.com/iainbeeston/gem_testcase