fake_sqs icon indicating copy to clipboard operation
fake_sqs copied to clipboard

Published 20 hours ago • verified publisher icon iain

Support Message Attributes

Open ncallaway opened this issue 10 years ago • 5 comments

This change supports message attributes by pulling them out of the request headers and storing them in the message object.

The receive action will generate the XML for any attributes stored on the message body.

ncallaway avatar Feb 02 '15 21:02 ncallaway

@iain why this wasn't merged?

PlugIN73 avatar Oct 11 '15 19:10 PlugIN73

@PlugIN73 because the build is broken and there are merge conflicts must be fixed before any consideration of merging can happen.

elliotchance avatar Oct 11 '15 22:10 elliotchance

Has this change been abandoned? Without this fix in, fake_sqs is not compatible with the AWS Java SDK

jonnyshaw89 avatar Feb 03 '16 16:02 jonnyshaw89

@jonnyshaw89 When I made this change the main branch had a failing build and I hadn't checked in on this PR since then. I'll get everything fixed up and resolve merge conflicts in the next couple of days.

ncallaway avatar Feb 03 '16 16:02 ncallaway

Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

elliotchance avatar Feb 10 '16 00:02 elliotchance