Andy Damevin

Results 224 comments of Andy Damevin

In https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/builditem/GeneratedResourceBuildItem.java#L9-L11 We should change the comment to recommend using `GeneratedStaticResourceBuildItem` which takes care of this.

In `AdditionalStaticResourceBuildItem` we should also explain that it's not made for generated resources and to use `GeneratedStaticResourceBuildItem` instead. `AdditionalStaticResourceBuildItem` should only be for prod, and maybe we should even remove...

@mcruzdev maybe I am missing something but I don't understand why you are creating the generated files on disk? As soon as a https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/builditem/GeneratedResourceBuildItem.java is created, it means you will...

Could we add a DevModeTest similar to this: https://github.com/quarkiverse/quarkus-web-bundler/blob/main/deployment/src/test/java/io/quarkiverse/web/bundler/test/WebBundlerDevModeTest.java

This is getting really close :)

@mcruzdev you also need to edit this: https://github.com/quarkusio/quarkus/blob/2bfd9cbb63b4511a36edc981ff8886f6b32a05d5/extensions/vertx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/devmode/NotFoundProcessor.java#L58 In order to display the generated routes in the 404

This is an awesome contribution by @mcruzdev on his free time 🙏🚀 This PR looks good to me, I'll test it with the web-bundler today. @gsmet @cescoffier @FroMage please give...

This issue is related (and could be fixed at once): https://github.com/quarkusio/quarkus/issues/37789

> `disableURIValidation` is not exposed for a reason: you want to validate URI. It's an attack vector. @cescoffier it's not entirely true The Java implementation or URI seems to not...

@cescoffier I agree, not sure what the best way forward. As the current issue is with dev-mode, maybe we could have an option to disable it only in dev-mode?