Julien Cretin
Julien Cretin
Thanks for opening an issue! Yes, binary size is a concern for this library, but only with LTO (because it heavily relies on the actual encoding being known at compile...
I'm back from vacation and could take a look. However I'm not able to reproduce. I tried `cargo bloat --release` in your repo but I only see: ``` 0.0% 0.1%...
Thanks! I was able to reproduce on your project with `cargo bloat -p route-weaver-router --release`. I'll take a look when I get time. I'm quite busy (and a bit sick)...
Sorry for the long delay. I tried to `#[inline(always)]` the API but the dead code is still not eliminated, so I went with the manual solution of providing features. In...
Actually, I'll probably postpone submitting that PR until I experiment with another idea that would bring much more benefit. I'm just afraid that it might make the API a bit...
Ok, my experiment using `StaticEncoding` (and making `Encoding` a dyn object) seems to provide similar benefits, but doesn't need features. It might still be a breaking change because I'll have...
I don't think so. The current design assumes inlining and dead-code elimination to work cross-crate. This seems to work rather well with LTO but not otherwise. The new design I...
Ok, I got some time to look into this again. I've created the `v3-preview` branch for now. It will eventually be merged in the `main` branch. It essentially provides a...
This is now merged in `main`. It will eventually be part of 3.0.0 (tracked by #106) but will probably be released as a "preview" module too (to catch possible usability...
Thanks for reaching out! This crate focuses (in this order) on: correctness, user experience, generality, performance. So SIMD implementations if they only target specific encodings would favor performance over generality,...