cytoscape.js-node-editing icon indicating copy to clipboard operation
cytoscape.js-node-editing copied to clipboard

Published 20 hours ago • verified publisher icon iVis-at-Bilkent

remove jquery dependency

Open marfyl opened this issue 2 years ago • 6 comments

  • remove jquery dependency on javascript code
  • remove all references in the readme file and demo htmls
  • code formatter
    • tabWidth: 4
    • singleQuote: true

Each file was formatted in a different way and cytoscape-node-editing.js file use several criterias at the same time, so I use the criteria shown above, since it were the most used inside the file. (If you want another criteria I can change it)

I think that in the future it would be good to add a .editorconfig file or .prettierrc.js file to maintain consistent coding styles for multiple developers working on the same project across various editors and IDEs. (I could add one if you want)

I hope this PR will help, anything let me know.

marfyl avatar Jul 25 '22 11:07 marfyl

@marfyl Thanks for the PR. I checked some other extensions we developed and it seems that we generally prefer tabWidth: 2. Can you also change it for this PR as tabWidth: 2?

hasanbalci avatar Aug 12 '22 12:08 hasanbalci

done! I just pushed the changes, thanks for the review.

marfyl avatar Aug 13 '22 14:08 marfyl

@marfyl Thanks for the changes. I reviewed the PR and it seems generally ok, but I noticed a bug in your version that doesn't exist in our version. You can see that in the below video I generated using undoable demo. Can you please check the cause of the problem?

https://user-images.githubusercontent.com/22586369/185083955-e55ba95f-f96f-4431-a391-f2f095129edc.mp4

hasanbalci avatar Aug 17 '22 09:08 hasanbalci

fixed, please refresh the cache to avoid problems

marfyl avatar Aug 27 '22 10:08 marfyl

Do you need anything else from my side to bring out a new product release? Anything else you need just let me know

marfyl avatar Aug 31 '22 23:08 marfyl

@marfyl Sorry for the late response. Your last commit fixed the error that I mentioned, but I now realized another bug during undo-redo operation. It is as follows: Correct behavior in master branch (when I undo, nodes return to their original position):

https://user-images.githubusercontent.com/22586369/189828948-357ca66d-8548-4d32-9742-f09c5009aea4.mp4

Behaviour in PR (nodes don't return to their original positions):

https://user-images.githubusercontent.com/22586369/189829169-45bebfc9-1f24-4b58-a9ed-86909d078ebd.mp4

hasanbalci avatar Sep 13 '22 06:09 hasanbalci