cytoscape.js-edge-editing icon indicating copy to clipboard operation
cytoscape.js-edge-editing copied to clipboard

Option to customize right click event

Open zoulayabd opened this issue 4 years ago • 12 comments

Thanks for your help earlier!

we need to open context menu of edges by left click event , and we would like to have an option evtType to customise cxttap event

https://github.com/iVis-at-Bilkent/cytoscape.js-edge-editing/blob/149c0aa59b0f5d2a39a3150b81f85f0f01105333/src/UIUtilities.js#L1286-L1367

zoulayabd avatar Nov 29 '21 09:11 zoulayabd

Hi @zoulayabd, You're right. Currently, context-menus extension has a evtType option but edge-editing extension is stick to the right-click. To solve this issue, we can expose the evtType option in the context-menus and then use it automatically in this extension. In this way, event type that is defined in context-menus will be available for edge-editing as well. We'll solve that when we have time.

hasanbalci avatar Dec 02 '21 04:12 hasanbalci

@zoulayabd With the last commits (c09acb395730bc101dc46fb3e11b25e0f36b09eb), it uses evtType of context-menus extension. Please check and close the issue if it's OK. (It is the unstable branch)

canbax avatar Feb 02 '22 12:02 canbax

@canbax thanks for your actions , i tried the solution on the unstable branch , but it give me this error : ERROR TypeError: G.getOptions is not a function init cytoscape-edge-editing.js:1

zoulay avatar Mar 15 '22 10:03 zoulay

@zoulay You also need to use the latest unstable context-menus This extension uses context-menus

canbax avatar Mar 15 '22 10:03 canbax

@canbax yes it works thanks , do you know when it will be released ?

zoulay avatar Mar 18 '22 09:03 zoulay

@zoulay That's great! I don't know when

canbax avatar Mar 18 '22 10:03 canbax

@canbax you didn't always know the date of release ? or a fix version that we can use on our project ?

zoulay avatar Apr 14 '22 13:04 zoulay

@canbax @hasanbalci , could you push a fix version that we can use on our project angular , Thanks for your actions

zoulay avatar Jun 02 '22 09:06 zoulay

@zoulay Inside the "package.json" file, you can the link to the unstable branch.

For example "cytoscape-edge-editing": "github:iVis-at-Bilkent/cytoscape.js-edge-editing#unstable",

canbax avatar Jun 02 '22 10:06 canbax

@canbax we can't deliver in production with this branch , could you please make a fix or release version

zoulay avatar Jun 27 '22 08:06 zoulay

I don't know when a release will happen or about a hotfix in the master branch. @hasanbalci and @ugurdogrusoz might help.

canbax avatar Jun 27 '22 08:06 canbax

Hi @zoulay, There have been many changes since the latest release of this extension, so we need to test it thoroughly before a new release. However, we currently don't have enough resources for that operation. If you want to use this unstable version, you can make your own release from a fork of this extension.

Please note that this extension uses context-menus extension as an optional dependency and the current changes in the unstable branch is also dependent to the changes in the unstable branch of context-menus extension. Therefore, you may need to make a release of the unstable branch of context-menus extension as well.

hasanbalci avatar Jun 27 '22 10:06 hasanbalci