cytoscape.js-cise icon indicating copy to clipboard operation
cytoscape.js-cise copied to clipboard

Performance issue

Open ugurdogrusoz opened this issue 4 years ago • 10 comments

According to @canbax When there are no clusters or just a small one, the performance is laggy. See https://github.com/ugurdogrusoz/visuall/issues/308.

ugurdogrusoz avatar Dec 01 '20 13:12 ugurdogrusoz

Related to this?

ugurdogrusoz avatar Dec 28 '20 07:12 ugurdogrusoz

I think this problem is not related to layout-utilities. I made a performance test and I see the below image image

You can see that calcRepulsionForcestakes too much time here, not the layout-utilities. I also attached the Performance Test file Profile-20201228T105931.json.zip

canbax avatar Dec 28 '20 08:12 canbax

Looks like the major problem with performance is due to not using the FR grid variant used by other force-directed layout algorithms we have like CoSE. Let's implement FR grid variant.

Let's also make sure repulsion forces are not redundantly (twice) calculated for in-circle nodes as we noticed.

ugurdogrusoz avatar Apr 22 '21 07:04 ugurdogrusoz

I fixed the in-circle node repulsion force calculation problem but because we developed the expanding circle model based on their moves, as it is approximately halved now, I decreased the escape limit to expand the circle, too. I tested the layouts, however, I'm not sure about the quality. @ugurdogrusoz hocam, could you check the quality?

herencalik avatar Apr 22 '21 13:04 herencalik

Looks reasonable @herencalik. Let's evaluate more carefully after FR grid variant is implemented.

ugurdogrusoz avatar Apr 26 '21 07:04 ugurdogrusoz

@canbax The performance should be improved now.

ugurdogrusoz avatar May 25 '21 08:05 ugurdogrusoz

I see an improvement but I still see a lag around 900-1000 ms. It is not too bad. It just makes a small freezing in the browser. This lag is around 50-100 ms in fcose.

canbax avatar Jun 01 '21 09:06 canbax

Can you please provide specific before & after numbers?

ugurdogrusoz avatar Jun 01 '21 12:06 ugurdogrusoz

https://github.com/ugurdogrusoz/visuall/issues/308#issuecomment-735829171 here I see it was around 1400-1500 ms. Now it is around 1000 ms.

canbax avatar Jun 01 '21 12:06 canbax

Let's sleep on this for a while and see the performance as is.

ugurdogrusoz avatar Oct 20 '21 10:10 ugurdogrusoz