viewer icon indicating copy to clipboard operation
viewer copied to clipboard

Application Crashes when trying to open the More Widget option from the Widget window.

Open Praful-Bentley opened this issue 2 months ago • 3 comments

Sometimes the application is crashing when trying to open the More Widget option from the Widget window as shown in the image

Image

With the following error.

Image

While other times the css appears to be broken.

https://github.com/user-attachments/assets/bcbeee4f-7aa8-4011-ba80-30e2bcb3fcf1

Praful-Bentley avatar Nov 06 '25 08:11 Praful-Bentley

I can reproduce the broken css, but have not yet reproduced the crash. Hope to have a fix in tomorrow.

If you can provide a repo with a reproduction of the crash, I'll take a look at that as well.

ben-polinsky avatar Nov 06 '25 21:11 ben-polinsky

https://github.com/iTwin/appui/issues/1372 might help with the "broken CSS" part (w/ some hints for the crash part as well). Need more details (used browser & React version is a good start) on how to repro https://react.dev/errors/185...

One idea to (potentially) address both of these issues is to replace the current Popup usage with iTwinUI Popover in the AppUI repo.

GerardasB avatar Nov 07 '25 12:11 GerardasB

One idea to (potentially) address both of these issues is to replace the current Popup usage with iTwinUI Popover in the AppUI repo.

Yeah, using <ThemeManager> instead of <ThemeProvider> fixes the css issue.

ben-polinsky avatar Nov 07 '25 15:11 ben-polinsky

@Praful-Bentley is this still relevant?

aruniverse avatar Nov 14 '25 16:11 aruniverse

@Praful-Bentley is this still relevant?

I can push my changes if so.

ben-polinsky avatar Nov 14 '25 16:11 ben-polinsky

I'd say let's fix this at AppUI layer. One more reason to use iTwinUI Popover: https://github.com/iTwin/appui/issues/1458

GerardasB avatar Nov 14 '25 18:11 GerardasB

One idea to (potentially) address both of these issues is to replace the current Popup usage with iTwinUI Popover in the AppUI repo.

Yeah, using <ThemeManager> instead of <ThemeProvider> fixes the css issue.

Image

On using the ThemeManager and using those expand icon, application crashed with a react setState error.

Image

Praful-Bentley avatar Nov 17 '25 06:11 Praful-Bentley

On using the ThemeManager and using those expand icon, application crashed with a react setState error.

Ah, I meant using it in the viewer package. Once the above PR is through we can update the Viewer.

ben-polinsky avatar Nov 17 '25 14:11 ben-polinsky

@Praful-Bentley please update these dependencies in your viewer app to 5.19.0 and let us know if the problem persists:

@itwin/appui-react @itwin/components-react @itwin/core-react @itwin/imodel-components-react

ben-polinsky avatar Nov 18 '25 14:11 ben-polinsky