itwinjs-core icon indicating copy to clipboard operation
itwinjs-core copied to clipboard

Node 22 support

Open GytisCepk opened this issue 1 year ago • 2 comments

PR status: Waiting for LTS (October 29th)

TODO:

  • [ ] Confirm that mobile is working
  • [ ] Resolve Node.js deprecations warnings coming from dependencies

GytisCepk avatar Oct 21 '24 14:10 GytisCepk

fyi @tcobbs-bentley

re " Confirm that mobile is working" usually mobile support comes later because this requires a new addon

aruniverse avatar Oct 21 '24 18:10 aruniverse

fyi @tcobbs-bentley

re " Confirm that mobile is working" usually mobile support comes later because this requires a new addon

Since I do have seemingly working Node 22 for both Android and iOS, I will attempt to verify they work with this PR.

tcobbs-bentley avatar Oct 21 '24 23:10 tcobbs-bentley

When I run display-test-app on an iPad using this PR's branch and my locally built add-on, I get an error:

Error: classIdsToClassNames argument missing

I think this is because my add-on build is not compatible. @aruniverse Do you know what version of the add-on I should build to be compatible with this PR? I was building the main branch from Tuesday.

tcobbs-bentley avatar Oct 24 '24 23:10 tcobbs-bentley

@GytisCepk @aruniverse I forgot to ask Gytis in my previous question, and I'm not sure if editing the question will send the appropriate email. Do either of you know what version of the add-on I should build locally to work with this PR?

tcobbs-bentley avatar Oct 24 '24 23:10 tcobbs-bentley

@GytisCepk @aruniverse I forgot to ask Gytis in my previous question, and I'm not sure if editing the question will send the appropriate email. Do either of you know what version of the add-on I should build locally to work with this PR?

Merge the latest. Don't know off the top off my head but sounds like some of the changes affan has been making recently.

aruniverse avatar Oct 24 '24 23:10 aruniverse

@GytisCepk @aruniverse I forgot to ask Gytis in my previous question, and I'm not sure if editing the question will send the appropriate email. Do either of you know what version of the add-on I should build locally to work with this PR?

Merge the latest. Don't know off the top off my head but sounds like some of the changes affan has been making recently.

It turns out that the latest Xcode changes how it deals with Swift Packages, and it is thus using the official package from its cache instead of my local build. I am trying to figure out how to work around this.

tcobbs-bentley avatar Oct 28 '24 20:10 tcobbs-bentley

My Node 22 for iOS build works with this PR. Checking on Android now.

tcobbs-bentley avatar Oct 28 '24 22:10 tcobbs-bentley

Node 22 for Android also works with this PR, so it looks like mobile is good.

tcobbs-bentley avatar Oct 28 '24 23:10 tcobbs-bentley