itwinjs-core Introduce vitest to core/quantity

Continuation of this effort: #7165

Oct 19 '24 14:10 anmolshres98

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Oct 19 '24 14:10 mergify[bot]

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Oct 20 '24 05:10 mergify[bot]

can you edit the launch.json debug profile for running core quantity tests to be the same as core bentley and common

Oct 21 '24 19:10 hl662

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Oct 22 '24 05:10 mergify[bot]

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Oct 23 '24 05:10 mergify[bot]

can you edit the launch.json debug profile for running core quantity tests to be the same as core bentley and common

done

Oct 23 '24 05:10 anmolshres98

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Oct 23 '24 20:10 mergify[bot]

My only feedback is that in some places you go from assert.strictEqual to vitest's toEqual, when technically they are slightly different including that strictEqual asserts the types are identical and toEqual doesn't (toStrictEqual would be the equivalent). If the tests pass I don't think this is worth changing though

Oct 24 '24 17:10 eringram

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Oct 30 '24 05:10 mergify[bot]

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Nov 09 '24 05:11 mergify[bot]