itwinjs-core icon indicating copy to clipboard operation
itwinjs-core copied to clipboard

implementing schema changeinfo, changeoptions, etc...

Open christophermlawson opened this issue 1 year ago • 2 comments

christophermlawson avatar Jul 23 '24 11:07 christophermlawson

It seems the only time we need that SchemaContextEditor in the SchemaEditChangeBase implementations is to add the edit info (and to call changeCancelled.

I think it would be cleaner if the adding to a context is done in the context since it also manages the changes. That would prevent a reference to the Editor in the ChangeInfo objects (which would be purely informative) and move the majority of change-tracking and reverting logic to the context only.

StefanApfel-Bentley avatar Sep 17 '24 07:09 StefanApfel-Bentley

After changes became edits, we need to update a few more places (file names, properties and methods especially in ChangeInfo/Options) :)

StefanApfel-Bentley avatar Sep 17 '24 07:09 StefanApfel-Bentley

This PR should remain open for now as it contains unfinished Schema Editing changes that we will most likely need in the future. This code should be reviewed for necessary changes, current conflicts resolved, and get buy-in from PR reviewers.

christophermlawson avatar Aug 11 '25 17:08 christophermlawson