itwinjs-core icon indicating copy to clipboard operation
itwinjs-core copied to clipboard

Refactor GraphicsProvider and add APIs for creating Seequent EVO tilesets

Open eringram opened this issue 1 year ago • 3 comments

This PR adds a new concept of TilesetCreators and UrlProviders:

  • The UrlProviders/ directory contains files with functions that call external services such as the mesh export service and Seequent EVO visualization service to retrieve urls to 3D tilesets
  • The TilesetCreators/ directory contains files with functions that create/initialize tilesets using these urls

A pair of new files in these directories are GeoscienceUrlProvider.ts and GeoscienceTileset.ts. GeoscienceUrlProvider.ts contains getGeoscienceTilesetUrl which retrieves a url to a 3D Tiles tileset.json from Seequent, as described above. GeoscienceTileset.ts contains createGeoscienceTileset which uses that url to create and attach a reality model using Viewport.displayStyle.attachRealityModel. These APIs are marked as @alpha because they are experimental in collaboration with Seequent.

Used to be #6904. This is a copy of that branch with the display test app changes removed.

eringram avatar Jun 28 '24 19:06 eringram

singleton class

Why?

pmconne avatar Jul 01 '24 17:07 pmconne

singleton class

Why?

Good point, we can make the functions static so we won't need a singleton.

The idea of the class is to centralise the access and generation of 3d tilesets.

danieliborra avatar Jul 01 '24 17:07 danieliborra

Why?

Good point, we can make the functions static so we won't need a singleton.

The class has been changed to have only static methods, and the singleton has been removed.

andremig-bentley avatar Jul 01 '24 20:07 andremig-bentley

This pull request is now in conflicts. Could you fix it @eringram? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

mergify[bot] avatar Jul 04 '24 16:07 mergify[bot]