itwinjs-core icon indicating copy to clipboard operation
itwinjs-core copied to clipboard

fix ios webpack5 config

Open aruniverse opened this issue 3 years ago • 8 comments

  • add native as an external module
  • ignore optional peer deps

aruniverse avatar Aug 02 '22 16:08 aruniverse

@markschlosseratbentley could you test this out and make sure the ios app builds?

aruniverse avatar Aug 02 '22 16:08 aruniverse

@markschlosseratbentley could you test this out and make sure the ios app builds?

We're not running into the OOM error from before now. Also, dta ios backend builds with the changes in here as well now. Looks like more work needs to be done to switch to consuming the native binaries on ios via xcframework so will come back to fixing dta ios after we release 3.3

aruniverse avatar Aug 03 '22 16:08 aruniverse

@mergifyio backport release/3.3.x

aruniverse avatar Aug 03 '22 16:08 aruniverse

backport release/3.3.x

🟠 Waiting for conditions to match

  • [ ] merged [:pushpin: backport requirement]

mergify[bot] avatar Aug 03 '22 16:08 mergify[bot]

@tcobbs-bentley @toddsouthenbentley can you verify this with the Mobile SDK? The DTA is still in a broken state so won't be able to verify that this is actually working.

FWIW, DTA needs to be updated to use the MobileSDK instead of the old way of using the npm packages.

calebmshafer avatar Aug 03 '22 16:08 calebmshafer

@calebmshafer I'm not sure what you mean. Do you just want us to test webpack 5 with the mobile SDK? If so, we can do that.

tcobbs-bentley avatar Aug 03 '22 20:08 tcobbs-bentley

@calebmshafer Also, Arun walked me through setting up @bentley/imodeljs-native as an external plugin (as is done in this PR), and unfortunately that is a definite no-go, as it results in two separate copies of the 350MB mobile native library being in the app.

tcobbs-bentley avatar Aug 03 '22 20:08 tcobbs-bentley

setting up @bentley/imodeljs-native as an external plugin (as is done in this PR), and unfortunately that is a definite no-go

I do think the native pkg should probably be an external; if we removed the CopyExternalPlugin thered only be 1 instance. We just need to figure out how to have the backend resolve the native library from xcframework

aruniverse avatar Aug 03 '22 21:08 aruniverse