imodel-native icon indicating copy to clipboard operation
imodel-native copied to clipboard

Add logging to gcs

Open DanRod1999 opened this issue 1 year ago • 2 comments

Add logging for GCS when workspaces are disabled, also add log for time taken to collect gcs data.

Add env var GEOCOORD_DIR which can specify where the asset dir is located.

DanRod1999 avatar May 03 '24 18:05 DanRod1999

/azp run imodel-native

DanRod1999 avatar May 08 '24 17:05 DanRod1999

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 08 '24 17:05 azure-pipelines[bot]

Add env var GEOCOORD_DIR which can specify where the asset dir is located.

Why? Who will use this?

pmconne avatar May 28 '24 12:05 pmconne

Add env var GEOCOORD_DIR which can specify where the asset dir is located.

Why? Who will use this?

Visualization/GPB want to use it when loading up GPB in the kubernetes clusters. This is related to one of the experiments during the pineapple viewer hackothon.

DanRod1999 avatar May 28 '24 13:05 DanRod1999

Visualization/GPB want to use it when loading up GPB in the kubernetes clusters. This is related to one of the experiments during the pineapple viewer hackothon.

The Initialize function takes the data directory as an argument. Silently overriding that input with an undocumented environment variable is gross and surprising. Did you consider permitting the application to configure PlatformLib::IKnownLocationsAdmin::_GetGeoCoordinateDataDirectory?

pmconne avatar May 28 '24 13:05 pmconne

I disagree with the whole concept of reading local data files. That capability should be removed entirely - it is not necessary and will only cause problems.

If somebody really wants to deliver GCS data with an application (I still don't understand why you can't use the cloud workspaces), they should use the existing api and add a local WorkspaceDb.

PLEASE DON'T DO THIS!

kabentley avatar Jun 12 '24 14:06 kabentley