itowns icon indicating copy to clipboard operation
itowns copied to clipboard

Published 20 hours ago • verified publisher icon iTowns

feat(3dtiles): add support for binary batch table

Open jailln opened this issue 2 years ago • 5 comments

Description

Motivation and Context

  • Improve 3D Tiles support
  • Fixes #1826 , #1830 and #919

Note: BinaryPropertyAccessor.js may also be used for parsing the binary content of the 3D Tiles feature table (not supported by itowns yet).

jailln avatar Apr 05 '22 10:04 jailln

Hello Vincent, Thanks for your contribution. Your PR is ready for review?

gchoqueux avatar Apr 06 '22 12:04 gchoqueux

Yes it is :slightly_smiling_face: I will just add more tests to pass the coverage check but it won't change the code already pushed.

jailln avatar Apr 06 '22 12:04 jailln

Hello @gchoqueux It's ready to be reviewed.

jailln avatar Apr 13 '22 08:04 jailln

I am currently busy I'll look at it as soon as I have some time

gchoqueux avatar Apr 14 '22 12:04 gchoqueux

I added the deprecation warning, added the breaking change message in the commit and rebased.

jailln avatar Oct 07 '22 09:10 jailln