Maxime Brazeilles
Maxime Brazeilles
Looks like to be used here too https://github.com/mjmlio/mjml/blob/master/packages/mjml-text/src/index.js#L50 Mh... I don't know what to do about this. Maybe add a text-align attribute that fallback to align to ensure retro compatibility...
I think we should support both `align` and `text-align` because you might want to have a `justify` for text-align in the div too
That look really great ! @kmcb777 can you take a look to get this merged ?
I'm not really experienced enough with ESM modules but this looks good to me to merge for next release ? Can you just resolve yarn lock conflict please
This should be good for 4.10 then ! i'm waiting for the CI and then merging this for 4.10
Well I guess we might need to refactor those absolute import then D: https://github.com/mjmlio/mjml/blob/master/packages/mjml-carousel/src/Carousel.js#L5
No worry you really did a good job already ! 👍 I'll try to take a look too, I wonder we can just remove those `/lib` to see if it...
@TrySound This change might increase the build size ? Is there any solution to that if so ?
Well maybe it's time for us to drop node 10 as it's no longer supported anyway. If it still works on node 12 I guess we can drop cjs ?
So can you remove node 10 from https://github.com/mjmlio/mjml/blob/master/.github/workflows/mjml-workflow.yml#L8 and CJS support ? And so sorry for thoses conflict I think we did some update on 4.10.1 D: