Maksym Ochenashko

Results 135 comments of Maksym Ochenashko

I've addressed the feedback.

The snapshot is `0.14-eadbb3d-SNAPSHOT`, it requires `resolvers += Resolver.sonatypeCentralSnapshots`.

Well, I checked the generated SQLs poorly. They are different. **3.4.1**, **3.5.0-M4**: ```sql insert into `settings` (`key`,`value`) values (?,?) on duplicate key update `key`=VALUES(`key`), `value`=VALUES(`value`) ``` **3.5.0-M5**: ```sql insert into...

Do you know if the current implementation is viable? If not, could you give me hints on how it can be improved?

Closed in favor of https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/13576.

I would be careful keeping non-spec functionality in the main repository. Eventually, the maintenance burden could catch us up. If it's really needed, you can implement it here: https://github.com/typelevel/otel4s-experimental.

Side note: If I'm not mistaken, all queues (unbound, bound, dropping, etc) are multi-producer/multi-consumer. If so, is there any plan to provide other specialized variants, such as multi-producer/single-consumer?

> > The dropping queue's normalized (per operation) allocation is 3x more than the bounded queue. > > The bounded queue uses `Async` to wrap an underlying unsafe queue, whereas...

Does it seamlessly propagate the context? At least from the examples, it seems it does.

@razvanz thanks for pointing out! I guess I linked the wrong task/PR, and it closed automatically.