hyperRail icon indicating copy to clipboard operation
hyperRail copied to clipboard

Occupancy score image doesn't show when further than 2 days in advance

Open pietercolpaert opened this issue 9 years ago • 3 comments

When searching for longer than 2 days in advance, the occupancy score image give an image not found. This is because the API doesn't return occupancy scores at all and the code to show the image doesn't work. We should refrain from showing an image more than two days in advance at this moment...

pietercolpaert avatar Nov 24 '16 11:11 pietercolpaert

See e.g., https://irail.be/route?to=http%3A%2F%2Firail.be%2Fstations%2FNMBS%2F008812005&from=http%3A%2F%2Firail.be%2Fstations%2FNMBS%2F008814472&date=151216&time=1156&timeSel=depart before the 12th of December :) screenshot from 2016-11-24 12-02-50

pietercolpaert avatar Nov 24 '16 11:11 pietercolpaert

Probably an if check that shows the undefined as a fallback?

screen shot 2016-11-24 at 12 29 12

src is set wrongly.

https://github.com/iRail/hyperRail/blob/master/resources/views/_partials/route/results.blade.php#L33 needs an if check

Haroenv avatar Nov 24 '16 11:11 Haroenv

Indeed!

pietercolpaert avatar Nov 24 '16 11:11 pietercolpaert