hyperRail icon indicating copy to clipboard operation
hyperRail copied to clipboard

Simplify Dependencies

Open xavez opened this issue 8 years ago • 17 comments

I couldn’t get it to run locally yet, but I can already see we can probably simplify a lot of dependencies:

  • [ ] Get rid of the ruby dependency by switching sass and compass to node-sass
  • [ ] Get rid of the bower dependency by installing all necessary packages via npm

Unfortunately, I cannot code & test it, since nothing works for me yet, otherwise, I’d have made a PR ;).

xavez avatar Jul 13 '16 06:07 xavez

I assign myself to it.

To @pietercolpaert I got almost a pr ready for this one.

Tjoosten avatar Jul 13 '16 21:07 Tjoosten

@Tjoosten great!

xavez avatar Jul 14 '16 06:07 xavez

@Tjoosten Sounds great! You're working on making hyperRail work with gulp instead of grunt, right?

pietercolpaert avatar Jul 14 '16 09:07 pietercolpaert

@pietercolpaert Yes slowly I will demolish grunt and replace it wilt Laravel Elixir that is based on the GulpJs systems

Tjoosten avatar Jul 15 '16 12:07 Tjoosten

@Tjoosten if you need a good example to start with, check out the gulp workflow here: https://github.com/getchopstick/chopstick-boilerplate/blob/master/gulpfile.js or here: https://github.com/mono-company/bedrock/blob/master/gulpfile.js. Not 100% relevant but architecturally a good example.

xavez avatar Jul 15 '16 20:07 xavez

@xavez i'm using the default laravel-elixir system for this.

@pietercolpaert can u describe the asset files. What is included in what asset file. Because it's a horrible experience for me reading these grunt files.

Tjoosten avatar Jul 15 '16 20:07 Tjoosten

@Tjoosten Sorry, I cannot help here. Maybe @bramdevries can?

pietercolpaert avatar Jul 16 '16 07:07 pietercolpaert

@Tjoosten Any update? Are you going to be able to PR this or should someone else do this?

pietercolpaert avatar Jul 19 '16 12:07 pietercolpaert

Maybe open a PR with the work already done so there can be collaboration? There are quite a bit of dependencies right now.

Haroenv avatar Aug 14 '16 20:08 Haroenv

Will do it later in the night if you don't mind

Tjoosten avatar Aug 14 '16 20:08 Tjoosten

Sure, I don't mind

Haroenv avatar Aug 14 '16 20:08 Haroenv

I wanted to tackle this (together with updating to a newer angular version and maybe look into other optimizations) but I couldn't get the server running, I have php but the composer thing just didn't work. Is there maybe a possibility to either help me or change that to make it easier to get started?

AdriVanHoudt avatar Oct 21 '17 16:10 AdriVanHoudt

What server are you trying to get running, or where are you stuck? Setting this project up is a pain, from the top of my head you need npm, compass, grunt and bower installed. I'll see if I can reduce the dependencies a bit next week if I have the time, wasn't aware of this issue.

Bertware avatar Oct 21 '17 17:10 Bertware

I just tried to run it from scratch. You do not really need to bower and grunt. These were the steps taken: (mind that you also now need php-intl, composer and npm installed):

git clone [email protected]:iRail/hyperRail.git
cd hyperRail/
cp .env.example .env
composer install
php artisan key:generate
chmod -R 777 storage/
npm install
php -S localhost:8081 -t public/

And your development version of the hyperRail app should be running at http://localhost:8081

I agree that this workflow is way too complex for a simple application like iRail.be and we should work on a better one. All suggestions to move towards that goal are welcome!

pietercolpaert avatar Oct 21 '17 19:10 pietercolpaert

I didn't do the env copy so maybe that was it :P, let me try again next week. I might do a pr to the readme first to make the install step clearer 😊

AdriVanHoudt avatar Oct 21 '17 20:10 AdriVanHoudt

@pietercolpaert Don't forget what's installed globally on your computer already ;) Had to install some tools like compass which weren't installed globally for me yet.

Bertware avatar Oct 21 '17 20:10 Bertware

@AdriVanHoudt Thanks! Looking forward!

@Bertware the client-side script builds are included in the repository, so it’s optional to get that up and running... Yet indeed, documentation can be better

pietercolpaert avatar Oct 22 '17 07:10 pietercolpaert