ImmersivePortalsMod icon indicating copy to clipboard operation
ImmersivePortalsMod copied to clipboard

made overwrite an inject cancelled mixin

Open Mysticpasta1 opened this issue 1 year ago • 2 comments

This removes a fast fail overwrite mixin that fails when the method becomes public, changing it to an injected cancelled at-head mixin keeps the same functionality but makes it to were if the original method becomes public it won't crash due to an overwrite fail

basically tldr fixes this bug.

[16:50:57] [Worker-ResourceReload-9/FATAL] [mixin/]: Mixin apply for mod imm_ptl_core failed imm_ptl.mixins.json:common.chunk_sync.MixinChunkMap_C from mod imm_ptl_core -> net.minecraft.server.level.ChunkMap: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException PRIVATE @Overwrite method m_183760_ in imm_ptl.mixins.json:common.chunk_sync.MixinChunkMap_C from mod imm_ptl_core cannot reduce visibiliy of PUBLIC target method

Mysticpasta1 avatar Feb 15 '24 00:02 Mysticpasta1

Which mod compatibility issue would you want to solve? Can you show me the code of the conflicting mixin?

qouteall avatar Feb 16 '24 04:02 qouteall

There really isn't another mixin it is just an AT or AW from any mod that changes it from private to public will cause a crash, this is fixed and tested in my 1000 mod modpack with the following PR, Overwrites can't change visibility even if the original method turns public by an AT or AW, this happens with connector mod in my 1000 mod modpack on curseforge for 1.20.1 forge

The modpack is called Mystic's Monstrosity The functionality of IP doesn't change just make the method compat with possibly 1 to multiple mods in the modpack

For further info I'm HauntedPasta1 on discord

Mysticpasta1 avatar Feb 16 '24 04:02 Mysticpasta1

@Mysticpasta1 I forgot to mention that, if that mod makes that method playerLoadedChunk public, that mod will use that method, but iPortal changes that method. So, simply removing the overwrite won't likely to make iPortal compatible with that mod, if I don't know how that mod uses the method playerLoadedChunk.

qouteall avatar Jul 13 '24 06:07 qouteall

That's why I didn't merge the PR in the first place. Anyway, thanks for your intention to contribute.

qouteall avatar Jul 13 '24 06:07 qouteall