Nikita Salnikov-Tarnovski

Results 69 comments of Nikita Salnikov-Tarnovski

Well, I think it is not very common one... I use testcontainers as a very convenient library to start/stop docker containers from my Java application. It is kinda "orchestrator", which...

Yes, that was what I thinking about. IMO ideally we should introduce new method `GenericContainer.kill`, which will result in `killContainerCmd` and change current `stop` method to do `stopContainerCmd`. But this...

Hei, guys. What do you think about marking this for 2.0 milestone? :)

I have taken a look how easy it would be for me to propose a PR. I was unable to find a suitable place for my new proposed methods. Currently...

> If I understood correctly a (maybe temporary) solution might be to create a non-recording / invalid span in the HTTP instrumentation, which due to the `ParentOrElse`-Sampler, would lead to...

Yes, we have a proposal right in the task's description: >If I understood correctly a (maybe temporary) solution might be to create a non-recording / invalid span in the HTTP...

I think the right way is to use one of the factory methods on `io.opentelemetry.trace.DefaultSpan`.

>refactor to make sure our tracers set attributes on Span.Builder instead of Span Yes, we want to do that eventually.

No, this functionality is not yet implemented.

> bump. Is there any workaround here in the meantime? Sampling of health checks is not ideal. The only known workaround is to write custom sampler. But I have plans...