iNavFlight
Remove legacy option of rebooting fc without using MSP
This can cause some issues with some devices, eg.:
https://github.com/betaflight/betaflight/pull/13572
Kudos to @hydra for identifying this on BF.
This is a useful function for scripts / tools. I would be sorry to see it removed ... we have a guard time around it to prevent misuse.
I understand it is pratical for simple scripts, but Cli reboot/dfu command or MSP_REBOOT messages would still work.
Would that be a good enough replacement for the single character reboot?
I understand it is pratical for simple scripts, but Cli reboot/dfu command or MSP_REBOOT messages would still work.
Would that be a good enough replacement for the single character reboot?
Having to enter the CLI is not really convenient either. If this is a problem for INAV, even with the guard time, then fine, remove it. Hacking up MSP_REBOOT in the shell is not so big a deal.
I didn't realize there was supposed to be a guard time, I have run into some random issues where the fc would reboot when I was trying to do something over msp, but that was probably due to my own buggy code. This is not written as merged yet.
As noted in the BF PR, using MSP_REBOOT is the correct way to tell the FC to enter a specific bootloader mode. IMHO guard times, arming checks and whatever other workaround/preventions/hacks that are put in place to prevent accidental reboots are all extra code and all require additional tests, maintenance, flash-space, etc. Less is more, YAGNI, etc...
