inav icon indicating copy to clipboard operation
inav copied to clipboard

Bidirectional DShot

Open heikobischoff opened this issue 4 years ago • 8 comments

Current Behavior

To use RPM filter, the ESC telemetry must be connected to the flight controller.

Desired Behavior

Most ESCs with BLHeli_32 and BLHeli_S are supporting bidirectional DShot. The ESC telemetry will be delivered to the flight controller by the motor wire.

Suggested Solution

Betaflight is supporting bidirectional DShot since version 4.0/4.1. It would be great to implement/adapt this feature in iNav.

Who does this impact? Who is this for?

Mostly all multirotor builds which want to take advantage of RPM filter without wiring an additonal line from the ESC to the flight controller.

Additional context

Link to the Betaflight RPM Filter page: https://github.com/betaflight/betaflight/wiki/Bidirectional-DSHOT-and-RPM-Filter

heikobischoff avatar Mar 29 '20 12:03 heikobischoff

Any chance to have it on nearest release?

denisiussion avatar Nov 28 '20 20:11 denisiussion

I'm not able to work on this right now, but unless anyone else is working on this, I'm planning to tackle this next.

harryjph avatar Apr 23 '21 16:04 harryjph

Be our guest mate!

pt., 23 kwi 2021, 18:48 użytkownik Harry Phillips @.***> napisał:

I'm not able to work on this right now, but unless anyone else is working on this, I'm planning to tackle this next.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iNavFlight/inav/issues/5549#issuecomment-825784419, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHMBG6PHPTNYYV3EAHQZCLTKGQHVANCNFSM4LV6V4IQ .

DzikuVx avatar Apr 23 '21 18:04 DzikuVx

Any plans (near or far) to implement it?

padcom avatar Jul 28 '21 20:07 padcom

@padcom I plan to do it, but it's quite complex and I don't understand the STM32's DMA architecture well enough at the moment. I've written an implementation for ESP32 so that I understand what goes on on the wire, I'm just fighting with DMA. Consider it a far plan, not a near one.

harryjph avatar Jul 30 '21 20:07 harryjph

@harry1453 Hi bro ! Any News about this feature ? Are you still working on it ?

Lot of people like me are waiting this to switch from Betaflight to Inav.

AADDZZ avatar Nov 21 '21 21:11 AADDZZ

Please, implement this option, it would be very useful. Even for esc like the Hobbywing rotor 60a blheli_32 which has no telemetry output.

Thanks guys!

RipperGOT avatar Jan 27 '22 11:01 RipperGOT

Any news on this feature being added?

krizw avatar May 12 '22 20:05 krizw

Since now the blheli s esc with bluejay firmware and the blheli32 esc have begun to give not only RPM, but also temperature via bidirection dshot, performing this issue would be very useful.

r1000ru avatar Apr 03 '23 09:04 r1000ru

There is a clone of the repository where this has already been done. Any chance to include it here?

Alex-TV avatar Jun 07 '23 10:06 Alex-TV

2023, still don't have bdshot supported yet?

There is a clone of the repository where this has already been done. Any chance to include it here?

lida2003 avatar Jun 21 '23 07:06 lida2003

Hey guys, it's my first comment here. I just switched from Betaflight to iNav as especially as a beginner I love to have the position fix feature to pause or even land easily, quite nice and Betaflight guys seem not to want to invest into this as they "mainly focus on performance" - oh man. Anyway, the bdshot is something which seems you want to have and I was quite sad that this is not supported yet, quite old request though. Any update or plans? Quick question, as Betaflight has integrated it and it's open source as well, isn't it easy to get the underlaying idea from their source code? Why is it so hard to get the best out of these two worlds and let each other inspire a bit?

fritzrichter avatar Aug 24 '23 15:08 fritzrichter

Hey guys, (...) I just switched from Betaflight to iNav (...) Quick question, as Betaflight has integrated it and it's open source as well, isn't it easy to get the underlaying idea from their source code?

Check this out: https://github.com/iNavFlight/inav/wiki/INAV-for-BetaFlight-users

danarrib avatar Aug 24 '23 16:08 danarrib

This is good news @DzikuVx ! What is the PR implementing this? Thanks

marianomd avatar Feb 02 '24 18:02 marianomd

It is issue is really completed? May be remove support blheli32 telemetry and add bdshot, that use and blheli32, and bluedjay, have rpm, voltage, currency and temperature?

r1000ru avatar Feb 04 '24 19:02 r1000ru

Why remove the telemetry option? That works fine. It would make no sense to remove it.

@DzikuVx has said a few times in his live streams that there is no intent to implement bidirectional DSHOT. I’m sure he mentioned that is can cause issues with the communications. Especially if longer cable runs are used.

MrD-RC avatar Feb 04 '24 20:02 MrD-RC

I am little confused, the feature request is closed without comment. Is that good or bad, does that mean that it will be implemented or that the feature request will be just ignored?

course-up avatar Feb 05 '24 08:02 course-up

I am little confused, the feature request is closed without comment. Is that good or bad, does that mean that it will be implemented or that the feature request will be just ignored?

DShot telemetry is supported, but not Bi-directional single-wire telemetry. from https://github.com/iNavFlight/inav/wiki/INAV-for-BetaFlight-users

@DzikuVx @MrD-RC @course-up @r1000ru I think it's closed as inav'll NOT support this feature, PLEASE correct me, if I'm wrong.

a) As I didn't see any PR about bdshort supported right now. b) @MrD-RC has stated "might cause issues with the communications, especially if longer cable runs are used."

Note: Just use 32bit ESC, which has UART telemetry.

lida2003 avatar Feb 05 '24 09:02 lida2003

So when closing, @DzikuVx should add the correct label, in this case wontfix or similar.

marianomd avatar Feb 10 '24 17:02 marianomd