inav icon indicating copy to clipboard operation
inav copied to clipboard

enable MSP override build flag by default

Open xznhj8129 opened this issue 1 year ago • 2 comments

I think this is safe to allow by default by now, a minority uses it but the chances of someone accidentally sending MSP RC commands is probably slim to none

xznhj8129 avatar Sep 01 '24 16:09 xznhj8129

I'm not so sure. With all the recent work with mLRS. There is potential that people will be sending MSP RC commands.

MrD-RC avatar Sep 27 '24 19:09 MrD-RC

I figured that it's an involved enough procedure that the possibility of someone sending them accidentally is pretty low, and you still need to set the override channels bitmask in CLI (ie: set msp_override_channels = 15 for 1,2,3,4) otherwise it has no effect on them

xznhj8129 avatar Sep 27 '24 19:09 xznhj8129

I never understood why this was a compile flag. If you buy or build a device that sends MSP RC commands, solder that MSP device to the UART, set it up in the Ports tab, and send RC channels from it - That's probably because you wanted to?

sensei-hacker avatar Jan 25 '25 01:01 sensei-hacker

I never understood why this was a compile flag. If you buy or build a device that sends MSP RC commands, solder that MSP device to the UART, set it up in the Ports tab, and send RC channels from it - That's probably because you wanted to?

Don't forget setting up MSP Override flight mode!

xznhj8129 avatar Jan 25 '25 04:01 xznhj8129

Also Rx.md and https://github.com/iNavFlight/inav/wiki/INAV-Remote-Management%2C-Control-and-Telemetry need to be updated to match.

sensei-hacker avatar May 25 '25 22:05 sensei-hacker

To clear the final blocker, you need to run src/utils/update_cli_docs.py and commit the result.

This will generate the settings document from CLI document from the yaml.

stronnag avatar May 26 '25 05:05 stronnag