inav-configurator
inav-configurator copied to clipboard
iNavFlight
[MASTER] Unreliable behaviour selecting tabs/saving settings
Current master seems to be unreliable when switching between tabs and when saving changes. e.g. : Advanced Tuning tab ... change WP turning smoothing setting ... click Save and Reboot. Reboots to Status screen but screen gets stuck loading ... you have to disconnect and connect again. On reconnecting the Status Screen works most of the time but can hang randomly. When you can connect WP turning smoothing setting in Advanced Tuning tab is unchanged ... save failed. The same happens for other settings in Advanced Tuning.
Console output when this happens indicates Settings saved in EEPROM:
Getting setting nav_land_minalt_vspd
F:\INAVDev\inav-configurator\js\msp\MSPHelper.js:3078 Getting setting nav_emerg_landing_speed
F:\INAVDev\inav-configurator\js\intervals.js:114 Killing all intervals except: global_data_refresh,msp-load-update,ltm-connection-check
F:\INAVDev\inav-configurator\js\msp\MSPHelper.js:1373 Setting set
F:\INAVDev\inav-configurator\js\msp\MSPHelper.js:640 Settings Saved in EEPROM
F:\INAVDev\inav-configurator\js\msp\MSPHelper.js:724 Reboot request accepted
F:\INAVDev\inav-configurator\js\intervals.js:114 Killing all intervals except: global_data_refresh,msp-load-update
F:\INAVDev\inav-configurator\js\intervals.js:114 Killing all intervals except: global_data_refresh,msp-load-
Changing setting in CLI works OK. Selecting other tabs sometimes needs a couple of tries because they also get stuck loading.
This is for FLYWOOF411 target on Windows 10.
Yup, there are issues with master . Several, I suppose we will save them one by one
I tried the latest changes including #2063 and it definitely seems much better especially on faster boards, e.g. F722. But it still has tab selection issues on slower boards, e.g. F411. You can select the Modes tab for instance, which loads quickly normally, and it'll load, then select the Adjustments tab, which also loads quickly, but then select the Modes tab again and it hangs and doesn't load. The Status tab also still fails to load reliably. I'm guessing this is a timing tweaking issue perhaps ?
However, the settings now save on Advanced Tuning even with the slower board which is probably more important. I also noticed the sensor status at the top now works correctly, that was a bit hit and miss before (showed a Mag but no GPS when no Mag was present but a GPS was).
This looks like issue with MSP load on slower boards. But we won't be supporting F411 in INAV 8 so probably priority of it is slightly lower now
Has anyone else noticed the OSD tab crashes if an ALT page is selected. Or if the save button is pressed in the OSD tab ? Windows build with F405 FC.
Has anyone else noticed the OSD tab crashes if an ALT page is selected. Or if the save button is pressed in the OSD tab ? Windows build with F405 FC.
I don't get a crash selecting ALT pages but I do if I try and Save. (F722 windows).
EDIT: Actually console log indicates a reboot was requested so maybe not crashing but rebooting when it didn't before ? It does seem to save changes:
DITIS 11
65F:\INAVDev\inav-configurator\js\msp\MSPHelper.js:1373 Setting set
F:\INAVDev\inav-configurator\tabs\osd.js:3260 save_to_eeprom
F:\INAVDev\inav-configurator\js\msp\MSPHelper.js:640 Settings Saved in EEPROM
F:\INAVDev\inav-configurator\js\msp\MSPHelper.js:724 Reboot request accepted
F:\INAVDev\inav-configurator\js\connection\connection.js:139 Connection with ID: 1 closed, Sent: 6920 bytes, Received: 15282 bytes
F:\INAVDev\inav-configurator\js\port_handler.js:48 PortHandler - Removed: COM3
F:\INAVDev\inav-configurator\js\port_handler.js:128 PortHandler - Found: COM3
F:\INAVDev\inav-configurator\js\serial_backend.js:185 Connecting to: COM3
F:\INAVDev\inav-configurator\js\connection\connection.js:88 Connection opened with ID: 1, Baud: 115200
Guys, if something does not work make a new ticket. It's hard to track comments in different tickets