OpenTX-Telemetry-Widget icon indicating copy to clipboard operation
OpenTX-Telemetry-Widget copied to clipboard

Fix maximum symbol.

Open her01n opened this issue 1 year ago • 3 comments

On Taranis, it is possible to switch between displaying actual and maximum values, using the rotary control. The symbol is displayed to signify the values are maximum/minimum. This is implemented with drawing text with special characters "\192" and "\193".

On my version and hardware, edgetx v2.10.5, opentx-telemetry-widget 2.2.5, transmitter taranis qx7 access, the characters are not displayed - the space on display is blank.

I propose to replace the special characters with up and down arrow drawed with "lcd.drawLine" and "lcd.drawPixel".

her01n avatar Dec 07 '24 14:12 her01n

Have you tested this on OpenTX ?

The reason for the issue is because EdgeTX changed the fonts (to a UTF-8 font for localisation). Have you checked if there is a a character ine the Edge font that can be used instead of a custom icon?

stronnag avatar Dec 11 '24 17:12 stronnag

The bug is not present on OpenTX 2.3.15. The fixed version works with OpenTX with no visual difference.

The character is not available in EdgeTX, or at least is not documented in here https://luadoc.edgetx.org/appendix/fonts. Left and right arrows are available, as are characters '^', 'v'.

her01n avatar Dec 14 '24 09:12 her01n

This should preferably be implemented using the EdgeTX special characters, rather than icon drawing. See https://luadoc.edgetx.org/part_iii_-_opentx_lua_api_reference/constants/special-character-constants

See also #121 for using specific OS dependent characters for OpenTX and EdgeTX

It would also be useful to fix other instances of "\19*" ("\194", "\195") in the same way.

Finally, any updated PR needs to be rebased on master and GH has obsoleted some of the earlier workflow artefacts.

stronnag avatar Jan 19 '25 15:01 stronnag