Conversations
Conversations copied to clipboard
iNPUTmice
Ability to send DTMF during audio-only calls
The UI is hidden behind a small "dial pad" icon in the top right to the left of the "chat bubble" icon that was already there.
This contribution is the result of the work of several volunteers under my direction, as well as a subsequent merge and bugfix by MattJ of Snikket. I am happy to rebase or squash these commits in various ways if desired, but kept the slightly messy history for now to keep attribution to all authors.
The minSDK bump sounds like a big commitment... Android 7 or bust? :(
/LE: typo big
@licaon-kter if that bump is unacceptable I think it won't be hard to pull in the small interface we depend on from there for this.
It's a big disturbance every time it's bumped.
First was to 21 at 2.0, then some magic brought it back down to 16 only to bump it up to 21 at libwebrtc M86.
Users care if they're left behind, eg. there was a rumor that the mythical 3.0 update will bump to 23 and that made people talk :)
And yet, there's a lot to be said about old devices and their security :(
Now, if you can avoid it, and it's not complicated....
Hi,
yes I saw that on Snikket master. Didn’t know what the plan was and I was even considering merging this back myself. So thank you for making the PR.
I think the most obvious thing is that the dialpad view should use DataBinding this should get rid of a lot of the findViewById boiler plate.
Sorry, for the confusion - I knew this PR was planned by singpolyma, and I intend to drop the variant in Snikket in favour of this one when it's merged. Especially with a better solution for avoiding the minSDK bump.
Is there anything preventing this from getting merged? GitHub says there's 1 change requested but I can't tell what it's referring to.
@mattchrist I believe I have resolved all the currently-requested changes