Handle "Visitors are not allowed to change their nicknames in this room"

[ericschdt]

Conversations 2.10.0+fcr

Issue

Cannot change username.

1. Profile page
2. Change name, click on apply
3. Repeat step 2) several times

Observed Result

2. ---> Name stays the same
3. ---> Name has changed at the profile page but the account gets disconnected from the MUC ---> After reconnecting the account, the new nick has been applied in the problematic MUC.

Expected Result

2. ---> Show error message

Debug log

09-26 19:11:17.096 D/conversations( 8610): unknown error in conference: <presence type="error" xml:lang="en" xmlns="jabber:client" from="[email protected]/userB" to="[email protected]/Conversations.C9ee"><x xmlns="http://jabber.org/protocol/muc"/><error type="cancel" code="405" xmlns="jabber:client"><not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xml:lang="en" xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Visitors are not allowed to change their nicknames in this room</text></error></presence>
09-26 19:11:23.806 D/conversations( 8610): [email protected]: pushing bookmarks via pep
09-26 19:11:23.894 D/conversations( 8610): [email protected]: 0 bookmarks have been removed
09-26 19:11:23.894 D/conversations( 8610): [email protected]: processing bookmark PEP event
09-26 19:11:23.902 D/conversations( 8610): [email protected]: 0 bookmarks have been removed
09-26 19:11:23.902 D/conversations( 8610): [email protected]: processing bookmark PEP event
09-26 19:11:23.907 D/conversations( 8610): [email protected]: joining conversation [email protected]/userB
09-26 19:11:23.907 D/conversations( 8610): [email protected]: running mam query [email protected], order=NORMAL, after=1632676240967391, catchup=true, ns=urn:xmpp:mam:2
09-26 19:11:23.945 D/conversations( 8610): unknown error in conference: <presence type="error" xml:lang="en" xmlns="jabber:client" from="[email protected]/userB" to="[email protected]/Conversations.C9ee"><x xmlns="http://jabber.org/protocol/muc"/><error type="cancel" code="405" xmlns="jabber:client"><not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xml:lang="en" xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Visitors are not allowed to change their nicknames in this room</text></error></presence>
09-26 19:11:23.957 D/conversations( 8610): [email protected]: finished mam after 0(0) messages. messages left=true count=469
09-26 19:11:23.958 D/conversations( 8610): [email protected]: found 0 pending receipt requests
09-26 19:11:25.515 D/conversations( 8610): reInit(hasExtras=false)
09-26 19:11:25.519 D/conversations( 8610): scrolledToBottomAndNoPending=true
09-26 19:11:25.519 D/conversations( 8610): jump to first unread message
09-26 19:11:25.607 D/conversations( 8610): ConversationFragment.onBackendConnected()
09-26 19:11:30.686 D/conversations( 8610): [email protected]: joining conversation [email protected]/userB
09-26 19:11:30.686 D/conversations( 8610): [email protected]: running mam query [email protected], order=NORMAL, after=1632676240967391, catchup=true, ns=urn:xmpp:mam:2
09-26 19:11:30.728 D/conversations( 8610): unknown error in conference: <presence type="error" xml:lang="en" xmlns="jabber:client" from="[email protected]/userB" to="[email protected]/Conversations.C9ee"><x xmlns="http://jabber.org/protocol/muc"/><error type="cancel" code="405" xmlns="jabber:client"><not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xml:lang="en" xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Visitors are not allowed to change their nicknames in this room</text></error></presence>
09-26 19:11:30.739 D/conversations( 8610): [email protected]: finished mam after 0(0) messages. messages left=true count=469
09-26 19:11:30.739 D/conversations( 8610): [email protected]: found 0 pending receipt requests
09-26 19:11:32.308 D/conversations( 8610): [email protected]: joining conversation [email protected]/userB
09-26 19:11:32.310 D/conversations( 8610): [email protected]: running mam query [email protected], order=NORMAL, after=1632676240967391, catchup=true, ns=urn:xmpp:mam:2
09-26 19:11:32.353 D/conversations( 8610): unknown error in conference: <presence type="error" xml:lang="en" xmlns="jabber:client" from="[email protected]/userB" to="[email protected]/Conversations.C9ee"><x xmlns="http://jabber.org/protocol/muc"/><error type="cancel" code="405" xmlns="jabber:client"><not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xml:lang="en" xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Visitors are not allowed to change their nicknames in this room</text></error></presence>
09-26 19:11:32.355 D/conversations( 8610): [email protected]: finished mam after 0(0) messages. messages left=true count=469
09-26 19:11:32.356 D/conversations( 8610): [email protected]: found 0 pending receipt requests
09-26 19:11:33.580 D/conversations( 8610): [email protected]: joining conversation [email protected]/userB
09-26 19:11:33.580 D/conversations( 8610): [email protected]: running mam query [email protected], order=NORMAL, after=1632676240967391, catchup=true, ns=urn:xmpp:mam:2
09-26 19:11:33.618 D/conversations( 8610): unknown error in conference: <presence type="error" xml:lang="en" xmlns="jabber:client" from="[email protected]/userB" to="[email protected]/Conversations.C9ee"><x xmlns="http://jabber.org/protocol/muc"/><error type="cancel" code="405" xmlns="jabber:client"><not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xml:lang="en" xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Visitors are not allowed to change their nicknames in this room</text></error></presence>
09-26 19:11:33.629 D/conversations( 8610): [email protected]: finished mam after 0(0) messages. messages left=true count=469
09-26 19:11:33.629 D/conversations( 8610): [email protected]: found 0 pending receipt requests
09-26 19:11:34.583 D/conversations( 8610): [email protected]: joining conversation [email protected]/userB
09-26 19:11:34.584 D/conversations( 8610): [email protected]: running mam query [email protected], order=NORMAL, after=1632676240967391, catchup=true, ns=urn:xmpp:mam:2
09-26 19:11:34.642 D/conversations( 8610): unknown error in conference: <presence type="error" xml:lang="en" xmlns="jabber:client" from="[email protected]/userB" to="[email protected]/Conversations.C9ee"><x xmlns="http://jabber.org/protocol/muc"/><error type="cancel" code="405" xmlns="jabber:client"><not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xml:lang="en" xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Visitors are not allowed to change their nicknames in this room</text></error></presence>
09-26 19:11:34.644 D/conversations( 8610): [email protected]: finished mam after 0(0) messages. messages left=true count=469
09-26 19:11:34.644 D/conversations( 8610): [email protected]: found 0 pending receipt requests