Conversations icon indicating copy to clipboard operation
Conversations copied to clipboard

Simple media quotes

Open Millesimus opened this issue 3 years ago • 2 comments

I waited a little with this PR, since I'm well aware that it is not a beautiful solution and that there is a better solution planned with The Rewrite. However, it has proven itself very useful in the last weeks (even for non tech-savvy folks) and it is available now.

What

The PR adds the "quote" option to media messages. If used, it creates a simple '>' quote that indicates the media type and the time it was sent. The media type is indicated through an Emoji (less strings to translate). The time is localised with readableTimeDifference to provide a consistent experience.

It is immediately compatible with other clients and nested quotes. If rich quotes are introduced, it could still remain as fallback.

Considerations

  1. Especially in MUCs, it might accidentally leak the locale. I think that's negligible, since the user sees the message before sending it (if it should become the fallback in rich media quotes, the locale is no longer needed for consistency and should be set to UTC to avoid accidental invisible leakage invisible for the user).
  2. What if two messages of the same media type are sent in the same minute? Seems to be an edge case, I didn't experience it in my daily usage the last weeks.

Again, thanks to my Tech Talk folks for suggesting as well as testing it. :)

Update

W.r.t. the second consideration, I added filesize to the quote. Hope this improves discernability.

Millesimus avatar Sep 20 '21 16:09 Millesimus

Regarding the date, any "just now" or relative "5 mins ago" stuff will look odd... tomorrow, right?

UTC might be the better choice but still baffling for the users, local time leaks timezone (then again Conversations doesn't hide local time fyi, eg. Gajim can query your info and get that)

licaon-kter avatar Sep 20 '21 16:09 licaon-kter

Regarding the date, any "just now" or relative "5 mins ago" stuff will look odd... tomorrow, right?

"Just now" is unproblematic, as the quoted media is in close vicinity. With "59 mins ago" it could be difficult to identify the quoted media, but it looks even more odd if A sends you a quote refering to "2021-09-20 13:08", but for you Conversations displays the quoted media message as "59 mins ago". At least, that's what I was thinking when deciding for this approach.

UTC might be the better choice but still baffling for the users,

I think this would become really complicated for users (at least if we assume that users often write with people in the same timezone; if your contacts are dispersed all over the world UTC might be more useful).

local time leaks timezone (then again Conversations doesn't hide local time fyi, eg. Gajim can query your info and get that)

Exactly, but it might still be relevant in public MUCs.

Millesimus avatar Sep 20 '21 17:09 Millesimus

Closing this because it has a conflict and is unlikely to be merged, anyways.

Millesimus avatar Jan 15 '23 07:01 Millesimus