iNKORE-NET
[BUG] Datepicker brush color style (including focus visuals) doesn’t match WinUI
Describe the bug
Datepicker brush color style (including focus visuals) doesn’t match WinUI.
the focus navigation also missing for the top part (Month year or up down) efected both datepicker flyout and calendarview (Only for focus navigation for calendarview the brush is already right)
Current:
WinUI:
Reproduction
Go to datepicker page > Navigate with tab or shift + tab
Suggested Solution
No response
Library Version
0.10.1
Operating System
Windows 11
Framework
.NET Framework
Framework Version
6
Source of Package
Self-Compiled
Additional Notes
No response
Validations
- [x] Check that there isn't already an issue that reports the same or similar problem.
- [x] Check that this is a bug in the library that should be fixed, not a feature, also this is not about the documentation. (Or please choose the right repo and template.)
- [x] This is one single problem, or a few problems with the same cause. (If you want to report multiple problems, please create one issue for every single problem.)
- [x] You've checked that this problem still exists in the latest version. (Keep in mind that we don't provide any support for old versions.)
- [x] You know that we can't guarantee that we will satisfy your request. This is not really our duty to do everything anyone asks for. Also, you will treat our staff, contributors, and other users with respect and kindness.
- [x] You're sure there's something wrong with the library itself, not how you're using it. (If you are having issues using it and need help, please go to discussion.)
Hi, yes the focus visual rounded corners issue was resolved for the datepicker. but I think there are still some adjustments needed as mentioned above such as the header brush for the CalendarDatePicker, the background brush, and the focus visual behavior as shown in the video below: Current:
https://github.com/user-attachments/assets/30f195f3-c85d-4c8e-8dec-ccb102f7d872
WinUI:
https://github.com/user-attachments/assets/95d37dd2-67b3-4a02-bebd-95fd343c6309
CalendarDatePicker Header was darker while the CalendarView was almost bland with non-header in WinUI:
WinUI:
CalendarDatePicker
CalendarView
Current:
CalendarDatePicker
CalendarDatePicker
The current CalendarDatePicker was brighter dan WinUI too:
Current:
WinUI:
As for focus visual, I find many controls have the rectangle focus visuals which does not match WinUI.
NavigationView:
Button:
SettingExpander, etc..
Not sure why this will happen🤔. IIRC, ModernWPF has rounded rectangle focus visuals for many controls.
As for focus visual, I find many controls have the rectangle focus visuals which does not match WinUI.
NavigationView:
Button:
SettingExpander, etc..
Not sure why this will happen🤔. IIRC,
ModernWPFhas rounded rectangle focus visuals for many controls.
I agree, in ModernWPF, it has rounded corners when I tested their library. Recently, @mou-haz has been working hard to improve this styling on https://github.com/iNKORE-NET/UI.WPF.Modern/pull/282. Even though some context menus and menu flyouts have small differences in the visual focus styling unlike on WinUI, I think most of it is already completed. Could you test the PR as well? Maybe we can find some bugs, missing styles, or consistency issues in there
@GID0317 I will test it during my free time. Thanks for letting me know!