UI.WPF.Modern icon indicating copy to clipboard operation
UI.WPF.Modern copied to clipboard

[Style] CommandBarFlyout

Open mou-haz opened this issue 6 months ago • 11 comments

fix #265

mou-haz avatar Jul 01 '25 02:07 mou-haz

Hey @GID0317 , can u take a look at this ?

mou-haz avatar Jul 01 '25 03:07 mou-haz

Hi, i can't compile the project for testing. the build is failing with MSB3030 because MSBuild is looking for satellite .resources.dll files for cultures like az-Latn-AZ, de-DE, ja-JP, etc

GID0317 avatar Jul 01 '25 04:07 GID0317

@GID0317 , i am not sure why you are getting this error, it builds fine on my end,

anyway, can u try again now ?

mou-haz avatar Jul 01 '25 15:07 mou-haz

@GID0317 , i am not sure why you are getting this error, it builds fine on my end,

anyway, can u try again now ?

Still same sadly, it's regarding the satellite resources. it's shown like missing res languages and only effect this one. so, I can't test this one sorry.

the error like this keep happens. since i build manually using cli:

C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\az-Latn-AZ\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\bs-Latn-BA\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\sr-Cyrl-RS\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\sr-Cyrl-BA\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\sr-Latn-RS\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\uz-Latn-UZ\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\ha-Latn-NG\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\zh-Hans\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\zh-Hant\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.

But looking at NotYoojun reply the WinUI3 doesn't use old UWP context menu animation again which current used:

https://github.com/user-attachments/assets/8803f8a8-2af2-440a-b452-4a1698c97f08

it should be like in WinUI:

https://github.com/user-attachments/assets/575a88c8-c865-49fc-a56c-99cdea15d92f

GID0317 avatar Jul 02 '25 05:07 GID0317

Some issues pop up for latest commits:

image

Jack251970 avatar Jul 03 '25 04:07 Jack251970

it should work fine now, but still trying to fix the close animation .

mou-haz avatar Jul 03 '25 18:07 mou-haz

It works well for me now👍

Jack251970 avatar Jul 04 '25 01:07 Jack251970

@Jack251970 @GID0317 @NotYoojun I think it's like the winui now, can you take a look ?

mou-haz avatar Jul 04 '25 14:07 mou-haz

@mou-haz It looks so gooood to me! Very fluent!

And I wonder if you can fix these two app icons?

image

Suggested changes:

<ui:AppBarButton
    Click="OnElementClicked"
    Label="Save"
    ToolTipService.ToolTip="Save">
    <ui:AppBarButton.Icon>
        <ui:FontIcon Icon="{x:Static ui:SegoeFluentIcons.Save}" />
    </ui:AppBarButton.Icon>

</ui:AppBarButton>
<ui:AppBarButton
    Click="OnElementClicked"
    Label="Delete"
    ToolTipService.ToolTip="Delete">
    <ui:AppBarButton.Icon>
        <ui:FontIcon Icon="{x:Static ui:SegoeFluentIcons.Delete}" />
    </ui:AppBarButton.Icon>

</ui:AppBarButton>

in CommandBarFlyoutPage.xaml

Jack251970 avatar Jul 04 '25 15:07 Jack251970

@Jack251970 done

mou-haz avatar Jul 04 '25 15:07 mou-haz

@Jack251970 @GID0317 @NotYoojun I think it's like the winui now, can you take a look ?

Hi, Sorry as before look like I can't test for this one. the error keeps showing for this fix. but based on Jack251970 images its already look good like WinUI. Nice works!

GID0317 avatar Jul 04 '25 15:07 GID0317