UI.WPF.Modern icon indicating copy to clipboard operation
UI.WPF.Modern copied to clipboard

Match the style of ComboBox up with WinUI 3

Open Aris-Offline opened this issue 8 months ago • 14 comments

Description

Image In the current version of iUWM, items just drop down under the button when clicking the ComboBox.

Image However, in the default styling of WinUI 3, the position of the ListItem is moved with the selected item.

Suggested Solution

Change the style of the ComboBox to match WinUI 3.

Alternative

No response

Contribution

Sorry I can't help solve the problem. I'm a designer, not a developer lol

Additional Notes

No response

Validations

  • [x] Check that there isn't already an issue that reports the same or similar problem.
  • [x] Check that this is a request that is a feature or something we can take action on, and also this is not about the documentation. (Or please choose the right repo and template.)
  • [x] This is one single feature, or a few features with the same core. (If you want to report multiple feature, please create one issue for every single feature.)
  • [x] You've checked that this feature is unavailable yet in the latest version.( Keep in mind that we don't provide any support for old versions.)
  • [x] You know that we can't guarantee that we will satisfy your request. This is not really our duty to do everything anyone asks for. Also, you will treat our staff, contributors, and other users with respect and kindness.
  • [x] You're sure it's something to enhance with the library itself, not how you're using it. (If you are having issues using it and need help, please go to discussion.)

Aris-Offline avatar Apr 12 '25 07:04 Aris-Offline

Please @Aris-Offline , can u take a look on this #269 and see if it works for your use case ?

mou-haz avatar Jun 28 '25 18:06 mou-haz

Hi,

I test this its working great in the combobox page "A ComboBox with its ItemsSource set" example Image

for the "An editable ComboBox" it seems the botom one a litle different from WinUI side: Current: Image

WinUI: Image

For the top one, which is a "ComboBox with items defined inline and its width set" it is not following the default WinUI behavior. In WinUI 3, it should only select the first item in the dropdown menu but not actually make it selected. Current: Image Image

WinUI: Image Image

GID0317 avatar Jul 02 '25 06:07 GID0317

On some case combobox in several places sadly also seem broken: splitview page the PaneBackground combobox: Image

on WinUI it should be like: Image

GridView page SelectionMode Current: Image Image

WinUI: Image Image

CalendarView Current: Image Image Image

WinUI: Image Image Image

Info badge page: Current: Image

WinUI: Image

AcrilicsBrush page Current: Image

WinUI: Image

RadialGradienBrush Page Current: Image Image

WinUI: Image Image

Settings card and Expander Current: Image Image Image Image Image

WinUI: Image Image Image Image Image

GID0317 avatar Jul 02 '25 06:07 GID0317

Hey @GID0317 , can u take a look now?

mou-haz avatar Jul 10 '25 23:07 mou-haz

Sorry for my late reply.

Thank you! Now, most of the listed issues above are fixed in the normal state. Unfortunately, I found it broken in the state where the bottom part did not fit, causing the combobox menu to push to the top and become bugged like in the images (CalendarView page combobox):

Image Image

on WinUI its should be anchored into the very bottom part (Multiple and bulgarian): Image Image

I also noticed the behavior also seems different for the dropdown for this case (On WinUI it only limited to Bulgarian and centered aligned into "Assamese"): Current: Image

WinUI: Image

Overall, mostly is fixed on normal state. just the settings card that seems still broken

GID0317 avatar Jul 11 '25 02:07 GID0317

Hey @GID0317, can u look at it again, i used a different approach for alignment, i think it is better now.

mou-haz avatar Jul 12 '25 00:07 mou-haz

Hi sorry for late reply I tested it, and overall, it works much better now. Good job!

the one left is the for the long combobox like in calendar view. the Bulgarian was get cut off. in WinUI it should not be cut off like on the current one. the other one is I've observed combo box behavior in the WinUI gallery, the settings app, and WhatsApp. It seems that when the combobox contains long items, it displays 13 items and anchors at the 7th item. the current one was still not anchored at the 7th items (WhatsApp language combobox, Settings Display Resolution combobox and WinUI3 Gallery CalendarView)

Image Image Image

Current: Image

WinUI: Image

GID0317 avatar Jul 12 '25 04:07 GID0317

Hey @GID0317 , can u take a look?

mou-haz avatar Jul 14 '25 15:07 mou-haz

Hi After testing, I unfortunately encountered a strange bug. The first time I clicked the combobox, it displayed an issue like:

Image Image

On the second click, the bug disappeared. overall, it looks much better than before now:

Image Image

GID0317 avatar Jul 14 '25 16:07 GID0317

Hey @GID0317, can u provide a video of how to trigger this bug?

mou-haz avatar Jul 14 '25 19:07 mou-haz

Hi, sure. here’s the video showing how I reproduce the bug:

https://github.com/user-attachments/assets/5abec727-c62d-4f83-a203-6d09a8bea768

GID0317 avatar Jul 15 '25 00:07 GID0317

@GID0317 , unfortunately i am unable to reproduce the bug on my end,

https://github.com/user-attachments/assets/3076b4a7-b2df-434a-97c4-4f29486697b6

did this bug happen in last commit only ? or did it happen before?

mou-haz avatar Jul 15 '25 01:07 mou-haz

On my case it had only happened on the latest commit, previously it didn't happen to me. after I dig deeper, I notice the bug starting to happen when i was on outside of 100% scale. Normally on WinUI it should works on all scale

https://github.com/user-attachments/assets/69471818-af2b-4fbe-a6e1-0d7383b6bf95

GID0317 avatar Jul 15 '25 04:07 GID0317

On my case it had only happened on the latest commit, previously it didn't happen to me. after I dig deeper, I notice the bug starting to happen when i was on outside of 100% scale. Normally on WinUI it should works on all scale

Bug.Prodution.2.mp4

Hi, it seems like this issue no longer occurs in the latest commit on my end

GID0317 avatar Jul 24 '25 05:07 GID0317