LLibrary icon indicating copy to clipboard operation
LLibrary copied to clipboard

LLibrary causing cascading lag on worldgen

Open duhadventure opened this issue 6 years ago • 11 comments

image LLibrary is causing cascading lag for the server and clients.

duhadventure avatar Jun 09 '18 18:06 duhadventure

LLibrary doesn't do any worldgen... What other mods do you have installed?

Gegy avatar Jun 09 '18 18:06 Gegy

https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/2361125-mowzies-mobs-fantasy-mobs-for-your-mc-world

duhadventure avatar Jun 09 '18 19:06 duhadventure

@BobMowzie any ideas on this? Could your mod be causing generation while in the LLibrary context?

Gegy avatar Jun 15 '18 20:06 Gegy

All worldgen in Mowzie's Mobs is called through this class: https://github.com/BobMowzie/MowziesMobs/blob/1.12/src/main/java/com/bobmowzie/mowziesmobs/server/world/MowzieWorldGenerator.java

I use the structure builder for the structures themselves, but I can't imagine that's an issue. What exactly is "cascading" worldgen lag?

BobMowzie avatar Jun 15 '18 20:06 BobMowzie

@BobMowzie Cascading generation refers to the generation of a chunk causing another to generate, typically caused by setting or getting blocks in neighboring chunks.

pau101 avatar Jun 16 '18 01:06 pau101

LLibrary never calls getBlockState, and only calls setBlockState from the StructureBuilder... huh

Gegy avatar Jun 16 '18 06:06 Gegy

Alright. Think I've found the issue: the syncing BlockEntity class sends update packets to all players, forcing them to load the chunk that the TE is in. Only weird thing is that shouldn't happen during chunk generation, so shouldn't cause that message.

EDIT: Nevermind that, Mowzie's Mobs doesn't have any classes extending BlockEntity.

Gegy avatar Jun 16 '18 06:06 Gegy

@duhadventure Is that the only other mod you have installed?

Gegy avatar Jun 16 '18 06:06 Gegy

I just got this issue too. Froze my game for ten seconds, and when it unfroze I had been murdered by an angry zombie. But I've got a laundry list of miscellaneous mods, from Thaumcraft to PrimitiveMobs (and Mowzie's Mobs, too, which is the reason I have LLibrary to begin with), so I'm not strictly sure that nothing's interfering.

plausibleusername avatar Jul 07 '18 19:07 plausibleusername

Know this is an old issue, but I am also having it, and yeah I also have a decent amount of mods installed

stardok4 avatar Jan 25 '21 05:01 stardok4

Oh, it’s possible that my structure generation was leaking into ungenerated chunks. You’ll have to disable Barako and the Wroughtnaut in the mod config to make this stop. Though I’ve never experienced any issues around it while playing.

BobMowzie avatar Jan 25 '21 05:01 BobMowzie