LLibrary icon indicating copy to clipboard operation
LLibrary copied to clipboard

AxisAlignedBB methods grow and expand have been swapped

Open TheGreyGhost opened this issue 6 years ago • 1 comments

I've just noticed that someone has swapped the method names for AxisAlignedBB grow and expand at some point since this library was written i.e. in the latest recommended Forge 1.12.2 release (version = "1.12.2-14.23.5.2768" mappings = "snapshot_20171003") grow is now expand, and vica versa.

This breaks a lot of code including for example

PartEntity: public void collideWithNearbyEntities() { List<Entity> entities = this.world.getEntitiesWithinAABBExcludingEntity(this, this.getEntityBoundingBox().expand(0.20000000298023224D, 0.0D, 0.20000000298023224D)); entities.stream().filter(entity -> entity != this.parent && !(entity instanceof PartEntity) && entity.canBePushed()).forEach(entity -> entity.applyEntityCollision(this.parent)); }

TheGreyGhost avatar Jun 01 '19 14:06 TheGreyGhost

Change occurred between 1.10 and 1.11

func_72314_b - grow in 1.11 (stable 31) func_72314_b - expand in 1.10.2 (stable 29)

TheGreyGhost avatar Jun 01 '19 14:06 TheGreyGhost