Jakub Trllo

Results 146 comments of Jakub Trllo

Anyways, good start. We can discuss more, when we start to apply them to repositories.

> printf style is slowing stuff down because it is always evaluated even in the case the log isn't emitted after all. In pyblish plugins are all logs emited, and...

I think we lack workfile API so it is still relevant.

I would consider `save_workfile_info` function in `ayon_core.pipeline.workfiles.utils` as the way how it can be done now. Re-open if I'm not right please.

> The Event system in AYON is blocking by default, right @iLLiCiTiT ? Yes it is. But it matters what should happen during the hooks, and what is the reason/use-case...

I wanted to ask very similar questions to @BigRoy 's but I wanted to wait for this first https://github.com/ynput/ayon-core/pull/1222#issuecomment-2782443206 . We really need to know what is the use-case. It's...

> There are also often customization about hierarchy where loaded stuff should end up - if you want to customize this - to add loaded model into very specific structure,...

Also important note is that this PR is adding 2 new classes and at about 10 new functions just to register and discover them, changing api functions for load. All...

> Ok, I might be just down beause I had to recently remove all uses of TypedDict from my code because we still support Python 3.7. I believe str |...

It is mergable, from my point of view the abstract methods are unnecessary, but I won't be the one who will use it.