it icon indicating copy to clipboard operation
it copied to clipboard

Run tests on Rails 6.1

Open JasonBarnabe opened this issue 3 years ago • 3 comments

JasonBarnabe avatar Dec 22 '20 03:12 JasonBarnabe

Coverage Status

Coverage remained the same at 100.0% when pulling 7ebff278962eb4d20b2c82c41c7c18241bb3e06f on JasonBarnabe:rails-6.1-test into 333dc274af96b44c6d3936e0e175c726dd2beed5 on iGEL:main.

coveralls avatar Dec 22 '20 03:12 coveralls

Rubcop complains, unrelated to my changes, that:

lib/it/plain.rb:4:5: W: Lint/MissingSuper: Call super to initialize state of the parent class.
    def initialize(template = '%s') ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I'm not sure if Plain needs to inherit from Tag, but the parameters to initialize seem different so calling super doesn't make sense. I've just disabled this cop.

JasonBarnabe avatar Dec 22 '20 03:12 JasonBarnabe

@iGEL Can you take a look at this? Thanks.

JasonBarnabe avatar Jan 02 '21 21:01 JasonBarnabe