pcsxr
pcsxr copied to clipboard
iCatButler
Linux input fixes
Before I made these changes I would have to close and re-open the configuration window each time after setting a single joystick key due to it copying my previous input every time I selected the "change" button.
This cleans up the code a little bit and makes it work somewhat better. The only lingering issue that I've come across is it has a little trouble with trigger axises (this was also present before the change).
At first glance the fix seems OK, will test it later today. On the other hand, the spacing fixes seem odd, the code mostly uses spaces for indentation and I don't see any reason for them to be replaced with tabs.
There was some inconsistency within the file (it was a mix of tabs and spaces in places) so I wasn't sure which to use. Either that or vim went on the fritz while I was making changes.
Let me know what you think about the functionality when you're able and I'll try to get the tabs converted over to spaces before I head to work.
Configuring my controls without this was quite a task. Lol.
On Fri, Mar 15, 2019, 4:24 AM Stelios Tsampas [email protected] wrote:
At first glance the fix seems OK, will test it later today. On the other hand, the spacing fixes seem odd, the code uses spaces for indentation and I don't see any reason for them to be replaced with tabs.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iCatButler/pcsxr/pull/12#issuecomment-473215350, or mute the thread https://github.com/notifications/unsubscribe-auth/ACvJZSjWAAieqMc4tN7z85HctVY1Xj5mks5vW2bYgaJpZM4bnk7s .
While trying to figure out haptic problems I'm having, I've noticed that this patch breaks building against SDL1:
cfg-gtk.c:(.text+0xccf): undefined reference to `SDL_FlushEvent'
I don't have a joystick with haptic feedback at the moment, but I'll take a peek at the old API and see if I can't get it building for you again at least.