Connor Tumbleson

Results 630 comments of Connor Tumbleson

Looks like I forgot to close this after it was fixed in: https://github.com/openai-php/client/pull/560

I'm a bit nervous that we move our implementation to a 3rd party wrapper package. It seems my argument is more with Laravel on why their HTTP Client isn't PSR-18...

Looks like this is already nullable - must have been fixed already. https://github.com/openai-php/client/blob/main/src/Responses/Threads/Messages/Delta/ThreadMessageDeltaObject.php#L51 Closing.

> `type.googleapis.com/google.rpc.BadRequest` would be more in line with OpenAI's type `invalid_request_error`, but `INVALID_ARGUMENT` is more informative imho. Probably the message/status of the higher object. I think you can ignore inner...

With a new method like this - I don't exactly remember it all by heart but you'll need to touch the interface, the mock and a simple test to keep...

Do you have any further context on the string `true`? I read the docs and it seems its a regular `bool` like the other stream endpoints. Rest looks solid -...

Ahh interesting. Thanks for all the info. Let me mess with this a bit (see impact on other endpoints, etc) and see.

I understand this is a highly requested feature so at some point we need to bite bullet and do something. Between the various attempts of a PSR-18 complaint integration and...