mojoportal icon indicating copy to clipboard operation
mojoportal copied to clipboard

Some images break Better Image Gallery

Open joeystombaugh opened this issue 1 year ago • 1 comments

something else When uploading the above image to better image gallery it gives an aw shucks. Checking the error log I got

System.OutOfMemoryException: Out of memory.
   at System.Drawing.Image.FromFile(String filename, Boolean useEmbeddedColorManagement)
   at mojoPortal.Features.UI.BetterImageGallery.BetterImageGalleryService.CreateThumbnails(FileInfo[] images, String thumbnailCachePath)
   at mojoPortal.Features.UI.BetterImageGallery.BetterImageGalleryService.SetupThumbnails()
   at mojoPortal.Features.UI.BetterImageGallery.BetterImageGalleryRazor.RenderContents(HtmlTextWriter output)
   at System.Web.UI.WebControls.WebControl.Render(HtmlTextWriter writer)

It is definitely an issue with the image but better image gallery should silently fail and not break like that.

joeystombaugh avatar Aug 02 '23 14:08 joeystombaugh

turns out the images in question were webp saved as jpg and that was causing System.Drawing to have issues. We should still catch the error gracefully.

JosephMDavis avatar Aug 02 '23 15:08 JosephMDavis