extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Adding Inclusive Gender Options for 10.1

Open rileypb opened this issue 1 year ago • 5 comments

rileypb avatar Mar 26 '23 23:03 rileypb

Phil -- I like it. Thank you. Four things:

  • I think the "singular-they" gender should simply be called "singular-they" or something like that. I'm uncomfortable using "non-conforming" for this. I use singular they myself. (This is just a singular-they implementation, right? It doesn't cover Zie/Zir, Spivak, etc.)
  • I'm completely willing to make this an update to my Gender Options extension. It's all stuff I would have done if I'd managed to get it tested and working. Since it's pretty clear that this is a modification to mine, could you give me a diff from mine to yours?
  • You'll need to update the credits lines at the top as best you can to credit my work and yours correctly. I credit other people's work, you need to credit my work. Quote from a best practices document:

The preferred way to provide credits in modified extensions is to add a third paragraph in the beginning of the extension, below the extension description, that is automatically printed when the extension is listed in the >VERSION info

So there should be a third paragraph after the extension description giving the joint author credits.

  • Did you update the tests? What are the new tests? Which singular-they situations work now which didn't work previously?

neroden avatar Mar 27 '23 17:03 neroden

Hi Nathanael, I tried to contact you a few months ago about this extension when I had added a fourth gender type and wanted to work on singular they. Zed Lopez contributed some code to make that work.

As to your points:

  1. Sounds reasonable, renamed.
  2. If you'd like to make this a new version of Gender Options by Nathanael Nerode, that's perfectly fine with me. I'll post a diff somewhere.
  3. Added - let me know if it's sufficient.
  4. Tests are updated, one test scenario has been added. I've added singular-they examples alongside the male/female/neuter examples. The new scenario tests third person story viewpoint.

rileypb avatar Mar 30 '23 20:03 rileypb

I just sent you the diff via PM on IntFiction.com.

rileypb avatar Mar 30 '23 20:03 rileypb

With regards to other pronouns, it can produce the correct text, but it can't recognize them of course, so I've left my test using zie/hir commented out.

rileypb avatar Mar 30 '23 20:03 rileypb

I like it, the latest version looks great.

I'm sorry you had trouble reaching me. I don't check the IntFiction forums much. And frankly, I've been completely swamped with high-priority real-world stuff, mostly Covid safety -- doctors's offices are routinely infecting people, including my partner, with Covid, because the doctor's aren't using the right respirator masks or air filters. It has to stop.

My email for FLOSS projects is ncn_floss10 AT fastmail DOT fm , if you want to contact me in the future. I will try to log in to IntFiction review the diff ASAP but I am very, very busy right now, and I might not get to it for a couple of weeks.

neroden avatar Apr 03 '23 15:04 neroden